Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error suppression for failed gherkin step #2745

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Fix error suppression for failed gherkin step #2745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
effec20
Fix error suppression for failed gherkin step
ktryniszewski-mdsol Jan 4, 2021
56fc0ec
Added fixes to unit tests to prove the issue
Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/interfaces/gherkin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module.exports = (text) => {
} catch (err) {
step.status = 'failed';
step.err = err;
return err;
throw err;
} finally {
step.endTime = Date.now();
event.dispatcher.removeListener(event.step.before, setMetaStep);
Expand Down
58 changes: 50 additions & 8 deletions test/unit/bdd_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,17 @@ const text = `
When I go to checkout process
`;

const checkTestForErrors = (test) => {
return new Promise((resolve, reject) => {
test.fn((err) => {
if (err) {
return reject(err);
}
resolve();
});
});
};

describe('BDD', () => {
beforeEach(() => {
clearSteps();
Expand Down Expand Up @@ -82,18 +93,49 @@ describe('BDD', () => {
});
});

it('should allow failed steps', (done) => {
it('should allow failed steps', async () => {
let sum = 0;
Given(/I have product with (\d+) price/, param => sum += parseInt(param, 10));
When('I go to checkout process', () => expect(false).is.false);
When('I go to checkout process', () => expect(false).is.true);
const suite = run(text);
expect('checkout process').is.equal(suite.title);
let errored = false;
suite.tests[0].fn((err) => {
errored = !!err;
expect(errored).is.exist;
done();
});
try {
await checkTestForErrors(suite.tests[0]);
return Promise.reject((new Error('Test should have thrown with failed step, but did not')));
} catch (err) {
const errored = !!err;
expect(errored).is.true;
}
});

it('handles errors in steps', async () => {
let sum = 0;
Given(/I have product with (\d+) price/, param => sum += parseInt(param, 10));
When('I go to checkout process', () => { throw new Error('errored step'); });
const suite = run(text);
expect('checkout process').is.equal(suite.title);
try {
await checkTestForErrors(suite.tests[0]);
return Promise.reject((new Error('Test should have thrown with error, but did not')));
} catch (err) {
const errored = !!err;
expect(errored).is.true;
}
});

it('handles async errors in steps', async () => {
let sum = 0;
Given(/I have product with (\d+) price/, param => sum += parseInt(param, 10));
When('I go to checkout process', () => Promise.reject(new Error('step failed')));
const suite = run(text);
expect('checkout process').is.equal(suite.title);
try {
await checkTestForErrors(suite.tests[0]);
return Promise.reject((new Error('Test should have thrown with error, but did not')));
} catch (err) {
const errored = !!err;
expect(errored).is.true;
}
});

it('should work with async functions', (done) => {
Expand Down