-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add admin trial start (#846) #288
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 95.64% 95.66% +0.01%
==========================================
Files 612 612
Lines 15770 15820 +50
==========================================
+ Hits 15084 15134 +50
Misses 686 686
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
=======================================
+ Coverage 95.56 95.57 +0.01
=======================================
Files 726 726
Lines 16178 16228 +50
=======================================
+ Hits 15459 15509 +50
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 95.64% 95.66% +0.01%
==========================================
Files 612 612
Lines 15770 15820 +50
==========================================
+ Hits 15084 15134 +50
Misses 686 686
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Have you tried using this in the admin and saving an unrelated field? I'm wondering if the "required" in line 26 of the admin.py
can lead to that
Should be fine as this isn't the normal page where you would edit all the fields, this is a separate page you navigate to on the admin actions drop down. |
Purpose/Motivation
Add an action in the Owners page on the Admin panel to manually start trials for any free tier orgs with the specified end date
Links to relevant tickets
codecov/engineering-team#846
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.