Add an isATSConfigured field to the repository GQL type #321
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=====================================
Coverage 95.63 95.63
=====================================
Files 730 730
Lines 16425 16431 +6
=====================================
+ Hits 15707 15713 +6
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 96.00% 96.01%
=======================================
Files 615 615
Lines 15914 15920 +6
=======================================
+ Hits 15279 15285 +6
Misses 635 635
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 96.00% 96.01%
=======================================
Files 615 615
Lines 15914 15920 +6
=======================================
+ Hits 15279 15285 +6
Misses 635 635
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rohitvinnakota-codecov
changed the title
rohitvinnakota-codecov
force-pushed
the
rvinnakota/ats-gql
branch
from
1ebc85e to
02eee64
Compare
rohitvinnakota-codecov
force-pushed
the
rvinnakota/ats-gql
branch
from
9ccd47a to
610d345
Compare
| @@ -283,6 +283,15 @@ def resolve_flags_measurements_backfilled(repository: Repository, info) -> bool: | |||
| return dataset.is_backfilled() | |||
|
|
|||
|
|
|||
| @repository_bindable.field("isATSConfigured") | |||
| def resolve_is_ats_configured(repository: Repository, info) -> bool: | |||
| if not repository.yaml or "flag_management" not in repository.yaml: | |||
There was a problem hiding this comment.
Also, have you double checked if you want the repository.yaml or some other yaml value? Check this fn out, UserYaml.get_final_yaml(...), the yaml can be from a commit, repo and/or org, so I'd double check on your end
There was a problem hiding this comment.
It looks like it is on the repository. Thanks for the caution here.
Purpose/Motivation
Adds a new gql field on a repo level to check if ATS is configured. This attribute will be consumed in gazebo to render a new ATS tab.
Links to relevant tickets
This PR relates to codecov/engineering-team#930. A follow up PR will add the
languagefield to the type.Repos with ATS configured have certain values in their YAML file. We have a similar check in worker.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.