-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add primary language field to repository GQL #323
[feat] Add primary language field to repository GQL #323
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
=====================================
Coverage 95.64 95.64
=====================================
Files 730 730
Lines 16433 16436 +3
=====================================
+ Hits 15716 15719 +3
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage ? 96.01%
=======================================
Files ? 615
Lines ? 15925
Branches ? 0
=======================================
Hits ? 15291
Misses ? 634
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage ? 96.01%
=======================================
Files ? 615
Lines ? 15925
Branches ? 0
=======================================
Hits ? 15291
Misses ? 634
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main discussion here: https://sentry.slack.com/archives/C04LW8R1M2N/p1704210521062999
Its fine to add this field to the GQL response, however beware what this language value represents and how it will be consumed. Its an arbitrary value retrieved from git providers' APIs, just because it shows one language doesn't mean that language exists in the repo nor does it mean it does not have any other languages.
codecov/engineering-team#811 (comment)
|
Purpose/Motivation
What is the feature? Why is this being done?
Following up from #321, adds the language field to the Repository type. This will be consumed in gazebo to conditionally render an
ATS
tab. This PR closes codecov/engineering-team#930.Links to relevant tickets
codecov/engineering-team#930
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.