feat: GithubAppInstallation model #346

giovanni-guidini · 2024-01-18T01:26:56Z

Model definitions for GithubAppInstallation.
This will unlock multiple apps for an org.
It also will improve how we keep track of what repos
an installation can access.

context: codecov/engineering-team#969

this is PR 1 of 2

Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. depends on: #346

codecov-staging · 2024-01-18T01:50:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

codecov-qa · 2024-01-18T01:50:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6be2a74) 96.06% compared to head (9796875) 96.07%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   96.06%   96.07%           
=======================================
  Files         624      625    +1     
  Lines       16171    16196   +25     
=======================================
+ Hits        15535    15560   +25     
  Misses        636      636

Flag	Coverage Δ
unit	`96.07% <100.00%> (+<0.01%)`	⬆️
unit-latest-uploader	`96.07% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codecov-public-qa · 2024-01-18T01:51:04Z

Codecov Report

Merging #346 (9796875) into main (6be2a74) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   96.06%   96.07%           
=======================================
  Files         624      625    +1     
  Lines       16171    16196   +25     
=======================================
+ Hits        15535    15560   +25     
  Misses        636      636

Flag	Coverage Δ
unit	`96.07% <100.00%> (+<0.01%)`	⬆️
unit-latest-uploader	`96.07% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ecov_auth/migrations/0048_githubappinstallation.py	`100.00% <100.00%> (ø)`
codecov_auth/models.py	`98.93% <100.00%> (+0.05%)`	⬆️
core/models.py	`94.71% <ø> (ø)`

Model definitions for GithubAppInstallation. This will unlock multiple apps for an org. It also will improve how we keep track of what repos an installation can access. context: codecov/engineering-team#969

codecov · 2024-01-18T14:49:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86431d3) 95.69% compared to head (ca8798d) 95.67%.
Report is 2 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #346     +/-   ##
=======================================
- Coverage   95.69   95.67   -0.02     
=======================================
  Files        738     740      +2     
  Lines      16670   16842    +172     
=======================================
+ Hits       15951   16112    +161     
- Misses       719     730     +11

Flag	Coverage Δ
unit	`96.07% <100.00%> (+<0.01%)`	⬆️
unit-latest-uploader	`96.07% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346

matt-codecov

i like the helper methods, nice touch

pls address comments but this'll defo do the trick

matt-codecov · 2024-01-18T19:25:14Z

codecov_auth/models.py

+GITHUB_APP_INSTALLATION_DEFAULT_NAME = "codecov_app_installation"
+
+
+class GithubAppInstallation(


do we also need an app id column? since we may use sentry's app or support multiple apps

the "installation_id" is the "app_id"

matt-codecov · 2024-01-18T19:25:58Z

codecov_auth/models.py

+    # replacement for owner.integration_id
+    # installation id GitHub sends us in the installation-related webhook events
+    installation_id = models.IntegerField(null=False, blank=False)
+    name = models.TextField(default=GITHUB_APP_INSTALLATION_DEFAULT_NAME)


what is this for?

I think this is what will differentiate the type of apps. As you mentioned above, we might use sentry's app or support multiple apps. This is how we know which is which.

codecov_auth/tests/unit/test_models.py

Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346

These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970

* feat: use GithubAppInstallation in api Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346 * refactor webhook handling related to gh app installation * use ghapp when getting torngit adapter Considers ghapp installations when deciding if a torngit adapter is for a repo with integration or not. If a ghapp installation exist then repo is considered to be using integration if it's covered by the installation. Otherwise previous behavior is used. The test `test_get_adapter_sets_token_to_bot_when_user_not_authenticated` includes `owner` as `None` when calling `RepoProviderService.get_adapter` so I'm assuming that can happen, and changing the typehint in the function. Other functions that were typehinted with `Owner` instead of `Optional[Owner]` are also changed.

These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970

giovanni-guidini mentioned this pull request Jan 18, 2024

feat: use GithubAppInstallation in api #347

Merged

giovanni-guidini force-pushed the gio/multi-apps/model branch from 32cbe7e to e0cb312 Compare January 18, 2024 01:41

feat: GithubAppInstallation model

a58ea09

Model definitions for GithubAppInstallation. This will unlock multiple apps for an org. It also will improve how we keep track of what repos an installation can access. context: codecov/engineering-team#969

giovanni-guidini force-pushed the gio/multi-apps/model branch from e0cb312 to a58ea09 Compare January 18, 2024 14:35

giovanni-guidini requested review from adrian-codecov, joseph-sentry and matt-codecov January 18, 2024 19:17

matt-codecov approved these changes Jan 18, 2024

View reviewed changes

giovanni-guidini and others added 2 commits January 18, 2024 16:49

update tests

ca8798d

Merge branch 'main' into gio/multi-apps/model

9796875

giovanni-guidini merged commit 635ff36 into main Jan 19, 2024
19 checks passed

giovanni-guidini deleted the gio/multi-apps/model branch January 19, 2024 00:05

giovanni-guidini added a commit to codecov/worker that referenced this pull request Jan 19, 2024

feat: GithubAppInstallation model

e15d378

These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970

giovanni-guidini mentioned this pull request Jan 19, 2024

feat: GithubAppInstallation model codecov/worker#236

Merged

giovanni-guidini added a commit to codecov/worker that referenced this pull request Jan 24, 2024

feat: GithubAppInstallation model

8030169

These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970

giovanni-guidini added a commit to codecov/worker that referenced this pull request Jan 26, 2024

feat: GithubAppInstallation model

a062340

These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970

giovanni-guidini added a commit to codecov/worker that referenced this pull request Jan 29, 2024

feat: GithubAppInstallation model (#236)

c8e780d

These changes port codecov/codecov-api#346 to the worker so we can use them here as well. context: codecov/engineering-team#970

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: GithubAppInstallation model #346

feat: GithubAppInstallation model #346

giovanni-guidini commented Jan 18, 2024 •

edited

Loading

codecov-staging bot commented Jan 18, 2024 •

edited

Loading

codecov-qa bot commented Jan 18, 2024 •

edited

Loading

codecov-public-qa bot commented Jan 18, 2024 •

edited

Loading

codecov bot commented Jan 18, 2024 •

edited

Loading

matt-codecov left a comment

matt-codecov Jan 18, 2024

giovanni-guidini Jan 18, 2024

matt-codecov Jan 18, 2024

giovanni-guidini Jan 18, 2024

		GITHUB_APP_INSTALLATION_DEFAULT_NAME = "codecov_app_installation"


		class GithubAppInstallation(

feat: GithubAppInstallation model #346

feat: GithubAppInstallation model #346

Conversation

giovanni-guidini commented Jan 18, 2024 • edited Loading

codecov-staging bot commented Jan 18, 2024 • edited Loading

Codecov Report

codecov-qa bot commented Jan 18, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Jan 18, 2024 • edited Loading

Codecov Report

codecov bot commented Jan 18, 2024 • edited Loading

Codecov Report

matt-codecov left a comment

Choose a reason for hiding this comment

matt-codecov Jan 18, 2024

Choose a reason for hiding this comment

giovanni-guidini Jan 18, 2024

Choose a reason for hiding this comment

matt-codecov Jan 18, 2024

Choose a reason for hiding this comment

giovanni-guidini Jan 18, 2024

Choose a reason for hiding this comment

giovanni-guidini commented Jan 18, 2024 •

edited

Loading

codecov-staging bot commented Jan 18, 2024 •

edited

Loading

codecov-qa bot commented Jan 18, 2024 •

edited

Loading

codecov-public-qa bot commented Jan 18, 2024 •

edited

Loading

codecov bot commented Jan 18, 2024 •

edited

Loading