feat: use GithubAppInstallation in api #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-guidini
force-pushed
the
gio/multi-apps/model
branch
from
32cbe7e to
e0cb312
Compare
giovanni-guidini
force-pushed
the
gio/multi-apps/api-usage
branch
from
1488a57 to
ed1f9b3
Compare
giovanni-guidini
force-pushed
the
gio/multi-apps/model
branch
from
e0cb312 to
a58ea09
Compare
giovanni-guidini
force-pushed
the
gio/multi-apps/api-usage
branch
2 times, most recently
from
0cb80ca to
643a512
Compare
giovanni-guidini
force-pushed
the
gio/multi-apps/api-usage
branch
from
643a512 to
01dfbb9
Compare
Codecov ReportAttention:
Changes have been made to critical files, which contain lines commonly executed in production. Learn more
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
+ Coverage 95.71 95.74 +0.03
=======================================
Files 740 740
Lines 16720 16847 +127
=======================================
+ Hits 16002 16129 +127
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
giovanni-guidini
force-pushed
the
gio/multi-apps/api-usage
branch
2 times, most recently
from
cbf7ebe to
7ec5900
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 96.05% 96.06%
=======================================
Files 628 628
Lines 16307 16357 +50
=======================================
+ Hits 15664 15713 +49
- Misses 643 644 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 96.05% 96.06%
=======================================
Files 628 628
Lines 16307 16357 +50
=======================================
+ Hits 15664 15713 +49
- Misses 643 644 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
requested review from
adrian-codecov,
joseph-sentry and
matt-codecov
giovanni-guidini
force-pushed
the
gio/multi-apps/api-usage
branch
from
7ec5900 to
9e31fbe
Compare
Uses the gh app installation WITHOUT compromising the old usage (of `owner.integration_id`). Deprecated paths are marked so. These changes don't backfill old data, but start using the new model with webhooks. the sample data from tests (the keys) are taken from [github docs](https://docs.github.com/en/webhooks/webhook-events-and-payloads#installation) and some amount of empirical data. depends on: #346
giovanni-guidini
force-pushed
the
gio/multi-apps/api-usage
branch
from
9e31fbe to
e2d2c92
Compare
| @@ -315,20 +322,45 @@ def determine_upload_pr_to_use(upload_params): | |||
| return upload_params.get("pr") | |||
|
|
|||
|
|
|||
| def ghapp_installation_id_to_use(repository: Repository) -> Optional[str]: | |||
There was a problem hiding this comment.
I'm debating if it makes sense to keep this fn here or if it makes sense to add it to the GithubAppInstallation as a method there, wdyt?
There was a problem hiding this comment.
I don't think this code should live as a method of GithubAppInstallation.
I think there's enough logic not related to GithubAppInstallation to leave it as is.
Plus in the future we might use this function to house logic to pick one GithubAppInstallation out of many that a user might have.
There was a problem hiding this comment.
That makes sense to me! Tyty
Considers ghapp installations when deciding if a torngit adapter is for a repo with integration or not. If a ghapp installation exist then repo is considered to be using integration if it's covered by the installation. Otherwise previous behavior is used. The test `test_get_adapter_sets_token_to_bot_when_user_not_authenticated` includes `owner` as `None` when calling `RepoProviderService.get_adapter` so I'm assuming that can happen, and changing the typehint in the function. Other functions that were typehinted with `Owner` instead of `Optional[Owner]` are also changed.
adrian-codecov
approved these changes
Jan 23, 2024
giovanni-guidini
added a commit
that referenced
this pull request
Jan 24, 2024
This reverts commit 86178ba. This commit caused auth issues with `/graphql` endpoint in which users were not authenticated and couldn't see source code. Revertign for now while we figure out the exact issue and fix it.
giovanni-guidini
added a commit
that referenced
this pull request
Jan 24, 2024
giovanni-guidini
added a commit
that referenced
this pull request
Jan 25, 2024
giovanni-guidini
added a commit
that referenced
this pull request
Jan 30, 2024
* Revert "Revert "feat: use GithubAppInstallation in api (#347)" (#355)" This reverts commit 226f73d. * fix: logged in users can't see coverage bug This bug caused a little incident in Codecov. The actual issue is that we can't make DB queries syncronously from an async context. When getting the file content we have to get an adapter, and that - since the GithubAppInstallation work - required a query to the database to get the default GithubAppInstallation for an `owner`. That was the actual error that caused the incident. Error surfacing was terrible in that endpoint so I changed the `info` log from an `exception` one so we can have a stacktrace. To actually fix the error I actually created an async version of `get_adapter`. I scanned the code, but it seems that this instance is the only place where we actually use this. * fix tests Tests for the interactor (which is async) are now marked as `async`. I believe that marking them with `@async_to_sync` instead of `pytest.mark.async` may have hidden the bug that we faced about running the DB query in the async context. Not tested this theory tho. * add more unit tests to async paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the gh app installation WITHOUT compromising
the old usage (of
owner.integration_id).Deprecated paths are marked so.
These changes don't backfill old data, but start using
the new model with webhooks.
the sample data from tests (the keys) are taken from
github docs
and some amount of empirical data.
depends on: #346
this is PR 2 of 2