Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customer intent column to owner profile table #390

Merged
merged 11 commits into from
Feb 12, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Feb 9, 2024

Purpose/Motivation

What is the feature? Why is this being done?

Adds a field that will be passed from gazebo to the saveTermsAgreement mutation(changes to be added in a following PR). The value for the new column is a text field that is either business or personal.

Links to relevant tickets

This closes codecov/engineering-team#1089

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (190e0a4) 96.07% compared to head (d61b97c) 96.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         633      634    +1     
  Lines       16555    16563    +8     
=======================================
+ Hits        15905    15913    +8     
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (190e0a4) 96.07% compared to head (d61b97c) 96.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         633      634    +1     
  Lines       16555    16563    +8     
=======================================
+ Hits        15905    15913    +8     
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...th/migrations/0049_ownerprofile_customer_intent.py 100.00% <100.00%> (ø)
codecov_auth/models.py 98.94% <100.00%> (+0.01%) ⬆️

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [Draft] Add customer intent column to owner profile table Add customer intent column to owner profile table Feb 12, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review February 12, 2024 15:41
@rohitvinnakota-codecov rohitvinnakota-codecov merged commit 38eb510 into main Feb 12, 2024
17 of 18 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/add-customer-intent-col branch February 12, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] - Add a column, “customer_intent”, to the OwnerProfile model.
2 participants