Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop customer intent column on owner profile table #395

Merged

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Feb 13, 2024

Purpose/Motivation

This PR effectively reverts #390. We want to add the column and store it on the users table instead.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [Draft] Drop customer intent column on owner profile table Drop customer intent column on owner profile table Feb 13, 2024
@rohitvinnakota-codecov rohitvinnakota-codecov force-pushed the rvinnakota/drop-customer-intent-owner-profile branch from dad42eb to 8ec8ea8 Compare February 13, 2024 22:03
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review February 13, 2024 22:03
@codecov-qa
Copy link

codecov-qa bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdd47db) 96.07% compared to head (56ea48e) 96.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         634      635    +1     
  Lines       16568    16568           
=======================================
  Hits        15918    15918           
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <100.00%> (ø)
unit-latest-uploader 96.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdd47db) 96.07% compared to head (56ea48e) 96.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         634      635    +1     
  Lines       16568    16568           
=======================================
  Hits        15918    15918           
  Misses        650      650           
Flag Coverage Δ
unit 96.07% <100.00%> (ø)
unit-latest-uploader 96.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ations/0050_remove_ownerprofile_customer_intent.py 100.00% <100.00%> (ø)
codecov_auth/models.py 98.93% <ø> (-0.02%) ⬇️

Impacted file tree graph

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdd47db) 95.76% compared to head (56ea48e) 95.76%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #395   +/-   ##
=====================================
  Coverage   95.76   95.76           
=====================================
  Files        750     751    +1     
  Lines      17088   17108   +20     
=====================================
+ Hits       16363   16383   +20     
  Misses       725     725           
Flag Coverage Δ
unit 96.07% <100.00%> (ø)
unit-latest-uploader 96.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitvinnakota-codecov rohitvinnakota-codecov merged commit 97dba25 into main Feb 14, 2024
18 of 20 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/drop-customer-intent-owner-profile branch February 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants