Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default branch logic #681

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Jul 15, 2024

Purpose/Motivation

What is the feature? Why is this being done?

We are seeing some issues in the UI where the default branch of main cannot be fetched. Since the git community uses main as default, we are updating our backend to reflect that.

This PR is a follow up from codecov/shared#289

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (4a45617) to head (2ce8927).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         632      632           
  Lines       17039    17039           
=======================================
  Hits        15628    15628           
  Misses       1411     1411           
Flag Coverage Δ
unit 91.71% <ø> (ø)
unit-latest-uploader 91.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/managers.py 0.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

codecov-public-qa bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (4a45617) to head (2ce8927).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         632      632           
  Lines       17039    17039           
=======================================
  Hits        15628    15628           
  Misses       1411     1411           
Flag Coverage Δ
unit 91.71% <ø> (ø)
unit-latest-uploader 91.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/managers.py 0.00% <ø> (ø)

Impacted file tree graph

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title Update default branch logic from master to main Update default branch logic Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (4a45617) to head (2ce8927).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##               main       #681   +/-   ##
===========================================
  Coverage   96.01000   96.01000           
===========================================
  Files           814        814           
  Lines         18390      18390           
===========================================
  Hits          17658      17658           
  Misses          732        732           
Flag Coverage Δ
unit 91.71% <ø> (ø)
unit-latest-uploader 91.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review July 23, 2024 16:58
@rohitvinnakota-codecov
Copy link
Contributor Author

Merging this on Monday, July 29 as we have a scheduled audit then.

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit a7f27af Jul 29, 2024
21 of 22 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/update-default-branch branch July 29, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants