Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename graphql testResults #871

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix: Rename graphql testResults #871

merged 3 commits into from
Oct 8, 2024

Conversation

suejung-sentry
Copy link
Contributor

Chatted with @ajay-sentry - Rename fields in the new testAnalytics type introduced in this PR to be more explicit
Before

{
   testAnalytics {
     results
     resultsAggregates
  }
}

After

{
   testAnalytics {
     testResults
     testResultsAggregates
  }
}

No frontend clients are hooked up to any of this yet so okay to make breaking change here

@suejung-sentry suejung-sentry requested a review from a team as a code owner October 8, 2024 17:14
@codecov-staging
Copy link

codecov-staging bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (3f4c348) to head (501c5b8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   96.34%   96.34%   -0.01%     
==========================================
  Files         823      823              
  Lines       19163    19161       -2     
==========================================
- Hits        18463    18461       -2     
  Misses        700      700              
Flag Coverage Δ
unit 92.71% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 92.71% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov codecov deleted a comment from codecov-public-qa bot Oct 8, 2024
@codecov codecov deleted a comment from codecov-qa bot Oct 8, 2024
@suejung-sentry suejung-sentry added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit e7bf4d0 Oct 8, 2024
18 of 19 checks passed
@suejung-sentry suejung-sentry deleted the sshin/fix/2287 branch October 8, 2024 18:30
@suejung-sentry
Copy link
Contributor Author

Relates to this ticket - codecov/engineering-team#2287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants