Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated testAnalytics graphql fields #873

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Oct 8, 2024

Remove fields that were duplicated in this api PR (+ follow-up rename PR). Frontend was cutover to the new fields in this gazebo PR.
So no remaining usages point to these fields.

Tested by confirming in staging no regression in the frontend behavior.

Closes codecov/engineering-team#2291

[DOT NOT MERGE - I'm tracking the requisite deps to merge in order so plz do not merge - will remove this message when ready] - we're ready! api deployed in cloud+ DEC and gazebo deployed to both

@suejung-sentry suejung-sentry marked this pull request as ready for review October 8, 2024 21:04
@suejung-sentry suejung-sentry requested a review from a team as a code owner October 8, 2024 21:04
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (79be58c) to head (6780e0b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
+ Coverage   96.29%   96.33%   +0.03%     
==========================================
  Files         823      823              
  Lines       19186    19156      -30     
==========================================
- Hits        18476    18453      -23     
+ Misses        710      703       -7     
Flag Coverage Δ
unit 92.69% <100.00%> (+0.02%) ⬆️
unit-latest-uploader 92.69% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Oct 8, 2024

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
2550 6 2544 6
View the top 3 failed tests by shortest run time
graphql_api.tests.test_test_result_legacy.TestResultTestCase test_fetch_test_result_last_duration
Stack Traces | 0.362s run time
self = &lt;graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_last_duration&gt;

    def test_fetch_test_result_last_duration(self) -&gt; None:
        query = """
            query {
               owner(username: "%s") {
                    repository(name: "%s") {
                        ... on Repository {
                            testResults {
                                edges {
                                    node {
                                        lastDuration
                                    }
                                }
                            }
                        }
                    }
                 }
            }
        """ % (self.owner.username, self.repository.name)
    
&gt;       result = self.gql_request(query, owner=self.owner)

graphql_api/tests/test_test_result_legacy.py:184: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = &lt;graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_last_duration&gt;
query = '\n            query {\n               owner(username: "randomOwner") {\n                    repository(name: "can") {...                      }\n                        }\n                    }\n                 }\n            }\n        '
provider = 'gh', owner = &lt;Owner: Owner&lt;github/randomOwner&gt;&gt;, variables = None
with_errors = False, okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
        self,
        query,
        provider="gh",
        owner=None,
        variables=None,
        with_errors=False,
        okta_signed_in_accounts=[],
        impersonate_owner=False,
    ):
        url = f"/graphql/{provider}"
    
        if owner:
            self.client = Client()
    
            if impersonate_owner:
                staff_owner = OwnerFactory(
                    name="staff_user", service="github", user=UserFactory(is_staff=True)
                )
                self.client.cookies = SimpleCookie({"staff_user": owner.pk})
                self.client.force_login_owner(staff_owner)
            else:
                self.client.force_login_owner(owner)
    
            if okta_signed_in_accounts:
                session = self.client.session
                session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
                session.save()
    
        response = self.client.post(
            url,
            {"query": query, "variables": variables or {}},
            content_type="application/json",
        )
&gt;       return response.json() if with_errors else response.json()["data"]
E       KeyError: 'data'

graphql_api/tests/helper.py:44: KeyError
graphql_api.tests.test_test_result_legacy.TestResultTestCase test_fetch_test_result_updated_at
Stack Traces | 0.367s run time
self = &lt;graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_updated_at&gt;

    def test_fetch_test_result_updated_at(self) -&gt; None:
        query = """
            query {
               owner(username: "%s") {
                    repository(name: "%s") {
                        ... on Repository {
                            testResults {
                                edges {
                                    node {
                                        updatedAt
                                    }
                                }
                            }
                        }
                    }
                 }
            }
        """ % (self.owner.username, self.repository.name)
    
&gt;       result = self.gql_request(query, owner=self.owner)

graphql_api/tests/test_test_result_legacy.py:97: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = &lt;graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_updated_at&gt;
query = '\n            query {\n               owner(username: "randomOwner") {\n                    repository(name: "PM") {\...                      }\n                        }\n                    }\n                 }\n            }\n        '
provider = 'gh', owner = &lt;Owner: Owner&lt;github/randomOwner&gt;&gt;, variables = None
with_errors = False, okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
        self,
        query,
        provider="gh",
        owner=None,
        variables=None,
        with_errors=False,
        okta_signed_in_accounts=[],
        impersonate_owner=False,
    ):
        url = f"/graphql/{provider}"
    
        if owner:
            self.client = Client()
    
            if impersonate_owner:
                staff_owner = OwnerFactory(
                    name="staff_user", service="github", user=UserFactory(is_staff=True)
                )
                self.client.cookies = SimpleCookie({"staff_user": owner.pk})
                self.client.force_login_owner(staff_owner)
            else:
                self.client.force_login_owner(owner)
    
            if okta_signed_in_accounts:
                session = self.client.session
                session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
                session.save()
    
        response = self.client.post(
            url,
            {"query": query, "variables": variables or {}},
            content_type="application/json",
        )
&gt;       return response.json() if with_errors else response.json()["data"]
E       KeyError: 'data'

graphql_api/tests/helper.py:44: KeyError
graphql_api.tests.test_test_result_legacy.TestResultTestCase test_fetch_test_result_name
Stack Traces | 0.369s run time
self = &lt;graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_name&gt;

    def test_fetch_test_result_name(self) -&gt; None:
        query = """
            query {
               owner(username: "%s") {
                    repository(name: "%s") {
                        ... on Repository {
                            testResults {
                                edges {
                                    node {
                                        name
                                    }
                                }
                            }
                        }
                    }
                 }
            }
        """ % (self.owner.username, self.repository.name)
    
&gt;       result = self.gql_request(query, owner=self.owner)

graphql_api/tests/test_test_result_legacy.py:71: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = &lt;graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_name&gt;
query = '\n            query {\n               owner(username: "randomOwner") {\n                    repository(name: "heavy")...                      }\n                        }\n                    }\n                 }\n            }\n        '
provider = 'gh', owner = &lt;Owner: Owner&lt;github/randomOwner&gt;&gt;, variables = None
with_errors = False, okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
        self,
        query,
        provider="gh",
        owner=None,
        variables=None,
        with_errors=False,
        okta_signed_in_accounts=[],
        impersonate_owner=False,
    ):
        url = f"/graphql/{provider}"
    
        if owner:
            self.client = Client()
    
            if impersonate_owner:
                staff_owner = OwnerFactory(
                    name="staff_user", service="github", user=UserFactory(is_staff=True)
                )
                self.client.cookies = SimpleCookie({"staff_user": owner.pk})
                self.client.force_login_owner(staff_owner)
            else:
                self.client.force_login_owner(owner)
    
            if okta_signed_in_accounts:
                session = self.client.session
                session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
                session.save()
    
        response = self.client.post(
            url,
            {"query": query, "variables": variables or {}},
            content_type="application/json",
        )
&gt;       return response.json() if with_errors else response.json()["data"]
E       KeyError: 'data'

graphql_api/tests/helper.py:44: KeyError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2556 tests with 6 failed, 2544 passed and 6 skipped.

View the full list of failed tests

pytest

  • Class name: graphql_api.tests.test_test_result_legacy.TestResultTestCase
    Test name: test_fetch_test_result_avg_duration

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_avg_duration>

    def test_fetch_test_result_avg_duration(self) -> None:
    query = """
    query {
    owner(username: "%s") {
    repository(name: "%s") {
    ... on Repository {
    testResults {
    edges {
    node {
    avgDuration
    }
    }
    }
    }
    }
    }
    }
    """ % (self.owner.username, self.repository.name)

    > result = self.gql_request(query, owner=self.owner)

    graphql_api/tests/test_test_result_legacy.py:213:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_avg_duration>
    query = '\n query {\n owner(username: "randomOwner") {\n repository(name: "behind"... }\n }\n }\n }\n }\n '
    provider = 'gh', owner = <Owner: Owner<github/randomOwner>>, variables = None
    with_errors = False, okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_test_result_legacy.TestResultTestCase
    Test name: test_fetch_test_result_commits_failed

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_commits_failed>

    def test_fetch_test_result_commits_failed(self) -> None:
    query = """
    query {
    owner(username: "%s") {
    repository(name: "%s") {
    ... on Repository {
    testResults {
    edges {
    node {
    commitsFailed
    }
    }
    }
    }
    }
    }
    }
    """ % (self.owner.username, self.repository.name)

    > result = self.gql_request(query, owner=self.owner)

    graphql_api/tests/test_test_result_legacy.py:126:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_commits_failed>
    query = '\n query {\n owner(username: "randomOwner") {\n repository(name: "hour") ... }\n }\n }\n }\n }\n '
    provider = 'gh', owner = <Owner: Owner<github/randomOwner>>, variables = None
    with_errors = False, okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_test_result_legacy.TestResultTestCase
    Test name: test_fetch_test_result_failure_rate

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_failure_rate>

    def test_fetch_test_result_failure_rate(self) -> None:
    query = """
    query {
    owner(username: "%s") {
    repository(name: "%s") {
    ... on Repository {
    testResults {
    edges {
    node {
    failureRate
    }
    }
    }
    }
    }
    }
    }
    """ % (self.owner.username, self.repository.name)

    > result = self.gql_request(query, owner=self.owner)

    graphql_api/tests/test_test_result_legacy.py:155:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_failure_rate>
    query = '\n query {\n owner(username: "randomOwner") {\n repository(name: "would")... }\n }\n }\n }\n }\n '
    provider = 'gh', owner = <Owner: Owner<github/randomOwner>>, variables = None
    with_errors = False, okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_test_result_legacy.TestResultTestCase
    Test name: test_fetch_test_result_last_duration

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_last_duration>

    def test_fetch_test_result_last_duration(self) -> None:
    query = """
    query {
    owner(username: "%s") {
    repository(name: "%s") {
    ... on Repository {
    testResults {
    edges {
    node {
    lastDuration
    }
    }
    }
    }
    }
    }
    }
    """ % (self.owner.username, self.repository.name)

    > result = self.gql_request(query, owner=self.owner)

    graphql_api/tests/test_test_result_legacy.py:184:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_last_duration>
    query = '\n query {\n owner(username: "randomOwner") {\n repository(name: "can") {... }\n }\n }\n }\n }\n '
    provider = 'gh', owner = <Owner: Owner<github/randomOwner>>, variables = None
    with_errors = False, okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_test_result_legacy.TestResultTestCase
    Test name: test_fetch_test_result_name

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_name>

    def test_fetch_test_result_name(self) -> None:
    query = """
    query {
    owner(username: "%s") {
    repository(name: "%s") {
    ... on Repository {
    testResults {
    edges {
    node {
    name
    }
    }
    }
    }
    }
    }
    }
    """ % (self.owner.username, self.repository.name)

    > result = self.gql_request(query, owner=self.owner)

    graphql_api/tests/test_test_result_legacy.py:71:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_name>
    query = '\n query {\n owner(username: "randomOwner") {\n repository(name: "heavy")... }\n }\n }\n }\n }\n '
    provider = 'gh', owner = <Owner: Owner<github/randomOwner>>, variables = None
    with_errors = False, okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError
  • Class name: graphql_api.tests.test_test_result_legacy.TestResultTestCase
    Test name: test_fetch_test_result_updated_at

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_updated_at>

    def test_fetch_test_result_updated_at(self) -> None:
    query = """
    query {
    owner(username: "%s") {
    repository(name: "%s") {
    ... on Repository {
    testResults {
    edges {
    node {
    updatedAt
    }
    }
    }
    }
    }
    }
    }
    """ % (self.owner.username, self.repository.name)

    > result = self.gql_request(query, owner=self.owner)

    graphql_api/tests/test_test_result_legacy.py:97:
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    self = <graphql_api.tests.test_test_result_legacy.TestResultTestCase testMethod=test_fetch_test_result_updated_at>
    query = '\n query {\n owner(username: "randomOwner") {\n repository(name: "PM") {\... }\n }\n }\n }\n }\n '
    provider = 'gh', owner = <Owner: Owner<github/randomOwner>>, variables = None
    with_errors = False, okta_signed_in_accounts = [], impersonate_owner = False

    def gql_request(
    self,
    query,
    provider="gh",
    owner=None,
    variables=None,
    with_errors=False,
    okta_signed_in_accounts=[],
    impersonate_owner=False,
    ):
    url = f"/graphql/{provider}"

    if owner:
    self.client = Client()

    if impersonate_owner:
    staff_owner = OwnerFactory(
    name="staff_user", service="github", user=UserFactory(is_staff=True)
    )
    self.client.cookies = SimpleCookie({"staff_user": owner.pk})
    self.client.force_login_owner(staff_owner)
    else:
    self.client.force_login_owner(owner)

    if okta_signed_in_accounts:
    session = self.client.session
    session[OKTA_SIGNED_IN_ACCOUNTS_SESSION_KEY] = okta_signed_in_accounts
    session.save()

    response = self.client.post(
    url,
    {"query": query, "variables": variables or {}},
    content_type="application/json",
    )
    > return response.json() if with_errors else response.json()["data"]
    E KeyError: 'data'

    graphql_api/tests/helper.py:44: KeyError

Copy link
Contributor Author

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot comments say there are failed tests but in the last run all tests were successful - https://github.com/codecov/codecov-api/actions/runs/11244392905/job/31262400259?pr=873

@suejung-sentry suejung-sentry added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit af3e62f Oct 9, 2024
30 of 32 checks passed
@suejung-sentry suejung-sentry deleted the sshin/2291 branch October 9, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.3] Clean Up Old API Implementation
2 participants