-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove deprecated testAnalytics graphql fields #873
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
+ Coverage 96.29% 96.33% +0.03%
==========================================
Files 823 823
Lines 19186 19156 -30
==========================================
- Hits 18476 18453 -23
+ Misses 710 703 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
❌ 6 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 2556 tests with View the full list of failed testspytest
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bot comments say there are failed tests but in the last run all tests were successful - https://github.com/codecov/codecov-api/actions/runs/11244392905/job/31262400259?pr=873
Remove fields that were duplicated in this api PR (+ follow-up rename PR). Frontend was cutover to the new fields in this gazebo PR.
So no remaining usages point to these fields.
Tested by confirming in staging no regression in the frontend behavior.
Closes codecov/engineering-team#2291
[DOT NOT MERGE - I'm tracking the requisite deps to merge in order so plz do not merge - will remove this message when ready]- we're ready! api deployed in cloud+ DEC and gazebo deployed to both