Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Client] - Commit Detail Page: Add New Table For Team Tier - Files Changed Tab #619

Closed
Tracked by #605
, #604
...
adrian-codecov opened this issue Sep 29, 2023 · 1 comment
Closed
Tracked by #605
, #604
...

[Client] - Commit Detail Page: Add New Table For Team Tier - Files Changed Tab #619

adrian-codecov opened this issue Sep 29, 2023 · 1 comment
Assignees
@nicholas-codecov
Labels
task

Comments

@adrian-codecov
Copy link

adrian-codecov commented Sep 29, 2023 •
edited
Loading

All client tickets will need to be under a feature flag, lets call it multipleTiers.

For designs, refer to this Figma, https://www.figma.com/file/YayQHDiX9uY7J7MVTtsVFX/Codecov-Light-Plan?type=design&node-id=114-894&mode=design&t=00iKU555hPCvkGi2-0

This change only affects users under the team tier. The remaining basic, pro, and enterprise tiers will offer the same content and views we normally do.

Blocked By

Task:

  • Investigate what hooks you'll need to create for the given table and make tickets for them. You should create tickets and work on them before you create the new table
  • Get rid of Lines 'Head %' and 'Change' column in the "files changes" tab
Screenshot 2023-10-23 at 1 18 07 PM
@adrian-codecov adrian-codecov mentioned this issue Sep 29, 2023
Closed
@adrian-codecov adrian-codecov changed the title [Client] - Commit Detail Page: Remove Table Columns for Lite Tier [Client] - Commit Detail Page: Add New Table For Team Tier Oct 10, 2023
@adrian-codecov adrian-codecov changed the title [Client] - Commit Detail Page: Add New Table For Team Tier [Client] - Commit Detail Page: Add New Table For Team Tier - Files Changed Tab Oct 23, 2023
This was referenced Oct 23, 2023
Open
Closed
Closed
@nicholas-codecov
Copy link

Done in codecov/gazebo#2309

nicholas-codecov added a commit to codecov/gazebo that referenced this issue Nov 1, 2023
@nicholas-codecov
feat: Hide Commits Page Team Files Changed Table for Public Repos (#2364
72cc111 
)

Add in check to show normal table for public repos when orgs are on the team plan.

GH codecov/engineering-team#619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicholas-codecov nicholas-codecov

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrian-codecov @nicholas-codecov