Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: swap the notification services #584

Merged
merged 2 commits into from
Aug 12, 2024

address review comment

31acdba
Select commit
Loading
Failed to load commit list.
Merged

feat: swap the notification services #584

address review comment
31acdba
Select commit
Loading
Failed to load commit list.
Codecov Notifications / codecov/project succeeded Aug 9, 2024 in 0s

97.59% (+0.00%) compared to 13e7e28

View this Pull Request on Codecov

97.59% (+0.00%) compared to 13e7e28

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         431      431           
  Lines       36073    36088   +15     
=======================================
+ Hits        35205    35220   +15     
  Misses        868      868           
Components Coverage Δ
NonTestCode 94.78% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.82% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/bundle_analysis/new_notify/__init__.py 100.00% <100.00%> (ø)
...e_analysis/new_notify/tests/test_notify_service.py 100.00% <100.00%> (ø)
services/bundle_analysis/new_notify/types.py 100.00% <100.00%> (ø)
tasks/bundle_analysis_notify.py 92.30% <100.00%> (-0.38%) ⬇️
...sks/tests/unit/test_bundle_analysis_notify_task.py 100.00% <100.00%> (ø)