-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: count seats for BA notify #654
Conversation
closes: codecov/engineering-team#2254 Aligning with coverage and test analytics, PR comment for BA will take up seats now.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #654 +/- ##
==========================================
- Coverage 98.05% 98.05% -0.01%
==========================================
Files 437 437
Lines 36849 36881 +32
==========================================
+ Hits 36134 36165 +31
- Misses 715 716 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #654 +/- ##
==========================================
- Coverage 98.05% 98.05% -0.01%
==========================================
Files 437 437
Lines 36849 36881 +32
==========================================
+ Hits 36134 36165 +31
- Misses 715 716 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #654 +/- ##
==========================================
- Coverage 98.05% 98.05% -0.01%
==========================================
Files 437 437
Lines 36849 36881 +32
==========================================
+ Hits 36134 36165 +31
- Misses 715 716 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
========================================
Coverage 98.10% 98.10%
========================================
Files 476 476
Lines 38170 38357 +187
========================================
+ Hits 37447 37632 +185
- Misses 723 725 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes This change has been scanned for critical changes. Learn more |
codecov_instance="self_hosted" if requires_license() else "cloud", | ||
codecov_name="your instance of Codecov" | ||
if requires_license() | ||
else "Codecov", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of these depend on requires_license()
. I would rather define a is_saas: bool
field for the template and match on that. In particular, the template already matches on codecov_instance
in a bunch of places, but the codecov_name
is being resolved in python code instead.
closes: codecov/engineering-team#2254
Aligning with coverage and test analytics, PR comment for BA will
take up seats now.