Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: count seats for BA notify #654

Merged
merged 2 commits into from
Aug 29, 2024
Merged

feat: count seats for BA notify #654

merged 2 commits into from
Aug 29, 2024

Conversation

giovanni-guidini
Copy link
Contributor

closes: codecov/engineering-team#2254

Aligning with coverage and test analytics, PR comment for BA will
take up seats now.

closes: codecov/engineering-team#2254

Aligning with coverage and test analytics, PR comment for BA will
take up seats now.
@giovanni-guidini giovanni-guidini requested a review from a team August 29, 2024 09:40
@codecov-notifications
Copy link

codecov-notifications bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
services/activation.py 60.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   98.05%   98.05%   -0.01%     
==========================================
  Files         437      437              
  Lines       36849    36881      +32     
==========================================
+ Hits        36134    36165      +31     
- Misses        715      716       +1     
Flag Coverage Δ
integration 98.05% <97.56%> (-0.01%) ⬇️
latest-uploader-overall 98.05% <97.56%> (-0.01%) ⬇️
unit 98.05% <97.56%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <95.55%> (+<0.01%) ⬆️
OutsideTasks 98.06% <97.56%> (-0.01%) ⬇️
Files Coverage Δ
...ces/bundle_analysis/new_notify/contexts/comment.py 98.75% <100.00%> (+0.33%) ⬆️
.../new_notify/contexts/tests/test_comment_context.py 100.00% <100.00%> (ø)
...ces/bundle_analysis/new_notify/messages/comment.py 100.00% <100.00%> (ø)
...analysis/new_notify/messages/tests/test_comment.py 100.00% <100.00%> (ø)
services/activation.py 93.10% <60.00%> (-6.90%) ⬇️

... and 6 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.05%. Comparing base (aea8367) to head (a607d0a).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/activation.py 60.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   98.05%   98.05%   -0.01%     
==========================================
  Files         437      437              
  Lines       36849    36881      +32     
==========================================
+ Hits        36134    36165      +31     
- Misses        715      716       +1     
Flag Coverage Δ
integration 98.05% <97.56%> (-0.01%) ⬇️
latest-uploader-overall 98.05% <97.56%> (-0.01%) ⬇️
unit 98.05% <97.56%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <95.55%> (+<0.01%) ⬆️
OutsideTasks 98.06% <97.56%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...ces/bundle_analysis/new_notify/contexts/comment.py 98.75% <100.00%> (+0.33%) ⬆️
.../new_notify/contexts/tests/test_comment_context.py 100.00% <100.00%> (ø)
...ces/bundle_analysis/new_notify/messages/comment.py 100.00% <100.00%> (ø)
...analysis/new_notify/messages/tests/test_comment.py 100.00% <100.00%> (ø)
services/activation.py 93.10% <60.00%> (-6.90%) ⬇️

... and 6 files with indirect coverage changes

Copy link

codecov-public-qa bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.05%. Comparing base (aea8367) to head (a607d0a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   98.05%   98.05%   -0.01%     
==========================================
  Files         437      437              
  Lines       36849    36881      +32     
==========================================
+ Hits        36134    36165      +31     
- Misses        715      716       +1     
Flag Coverage Δ
integration 98.05% <97.56%> (-0.01%) ⬇️
latest-uploader-overall 98.05% <97.56%> (-0.01%) ⬇️
unit 98.05% <97.56%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.91% <95.55%> (+<0.01%) ⬆️
OutsideTasks 98.06% <97.56%> (-0.01%) ⬇️
Files Coverage Δ
...ces/bundle_analysis/new_notify/contexts/comment.py 98.75% <100.00%> (+0.33%) ⬆️
.../new_notify/contexts/tests/test_comment_context.py 100.00% <100.00%> (ø)
...ces/bundle_analysis/new_notify/messages/comment.py 100.00% <100.00%> (ø)
...analysis/new_notify/messages/tests/test_comment.py 100.00% <100.00%> (ø)
services/activation.py 93.10% <60.00%> (-6.90%) ⬇️

... and 6 files with indirect coverage changes

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.10%. Comparing base (aea8367) to head (a607d0a).
Report is 6 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/activation.py 60.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #654    +/-   ##
========================================
  Coverage   98.10%   98.10%            
========================================
  Files         476      476            
  Lines       38170    38357   +187     
========================================
+ Hits        37447    37632   +185     
- Misses        723      725     +2     
Flag Coverage Δ
integration 98.05% <97.56%> (-0.01%) ⬇️
latest-uploader-overall 98.05% <97.56%> (-0.01%) ⬇️
unit 98.05% <97.56%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <95.55%> (-0.01%) ⬇️
OutsideTasks 98.06% <97.56%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...ces/bundle_analysis/new_notify/contexts/comment.py 98.75% <100.00%> (+0.33%) ⬆️
.../new_notify/contexts/tests/test_comment_context.py 100.00% <100.00%> (ø)
...ces/bundle_analysis/new_notify/messages/comment.py 100.00% <100.00%> (ø)
...analysis/new_notify/messages/tests/test_comment.py 100.00% <100.00%> (ø)
services/activation.py 93.10% <60.00%> (-6.90%) ⬇️

... and 6 files with indirect coverage changes

This change has been scanned for critical changes. Learn more

Comment on lines 78 to 81
codecov_instance="self_hosted" if requires_license() else "cloud",
codecov_name="your instance of Codecov"
if requires_license()
else "Codecov",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these depend on requires_license(). I would rather define a is_saas: bool field for the template and match on that. In particular, the template already matches on codecov_instance in a bunch of places, but the codecov_name is being resolved in python code instead.

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 1a56eea Aug 29, 2024
23 of 26 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/ba-seats branch August 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure that Bundle Analysis users take up a seat when used on private repos (match coverage)
2 participants