Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: count seats for BA notify #654

Merged
merged 2 commits into from
Aug 29, 2024

address feedback: move more logic to template

a607d0a
Select commit
Loading
Failed to load commit list.
Merged

feat: count seats for BA notify #654

address feedback: move more logic to template
a607d0a
Select commit
Loading
Failed to load commit list.
Codecov Notifications / codecov/project succeeded Aug 29, 2024 in 0s

98.05% (-0.01%) compared to aea8367, passed because coverage increased by -0.01% when compared to adjusted base (98.05%)

View this Pull Request on Codecov

98.05% (-0.01%) compared to aea8367, passed because coverage increased by -0.01% when compared to adjusted base (98.05%)

Details

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
services/activation.py 60.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   98.05%   98.05%   -0.01%     
==========================================
  Files         437      437              
  Lines       36849    36881      +32     
==========================================
+ Hits        36134    36165      +31     
- Misses        715      716       +1     
Components Coverage Δ
NonTestCode 95.91% <95.55%> (+<0.01%) ⬆️
OutsideTasks 98.06% <97.56%> (-0.01%) ⬇️
Files Coverage Δ
...ces/bundle_analysis/new_notify/contexts/comment.py 98.75% <100.00%> (+0.33%) ⬆️
.../new_notify/contexts/tests/test_comment_context.py 100.00% <100.00%> (ø)
...ces/bundle_analysis/new_notify/messages/comment.py 100.00% <100.00%> (ø)
...analysis/new_notify/messages/tests/test_comment.py 100.00% <100.00%> (ø)
services/activation.py 93.10% <60.00%> (-6.90%) ⬇️

... and 6 files with indirect coverage changes