-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove double-async_to_sync
#672
Conversation
The `save_parallel_report_to_archive` function was recently refactored to not be `async` anymore. However the `async_to_sync` wrapper was still doing its job, running the function in an async context on a background thread. This has lead to an error inside that function which was also calling `async_to_sync` internally. Fixes WORKER-P4B
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 97.94% 98.06% +0.12%
==========================================
Files 434 434
Lines 36627 36626 -1
==========================================
+ Hits 35873 35919 +46
+ Misses 754 707 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 97.94% 98.06% +0.12%
==========================================
Files 434 434
Lines 36627 36626 -1
==========================================
+ Hits 35873 35919 +46
+ Misses 754 707 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 97.94% 98.06% +0.12%
==========================================
Files 434 434
Lines 36627 36626 -1
==========================================
+ Hits 35873 35919 +46
+ Misses 754 707 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 97.99% 98.11% +0.12%
==========================================
Files 474 474
Lines 37953 37952 -1
==========================================
+ Hits 37191 37237 +46
+ Misses 762 715 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes This change has been scanned for critical changes. Learn more |
The
save_parallel_report_to_archive
function was recently refactored to not beasync
anymore. However theasync_to_sync
wrapper was still doing its job, running the function in an async context on a background thread.This has lead to an error inside that function which was also calling
async_to_sync
internally.Fixes WORKER-P4B