Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double-async_to_sync #672

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Remove double-async_to_sync #672

merged 1 commit into from
Sep 2, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Sep 2, 2024

The save_parallel_report_to_archive function was recently refactored to not be async anymore. However the async_to_sync wrapper was still doing its job, running the function in an async context on a background thread.

This has lead to an error inside that function which was also calling async_to_sync internally.

Fixes WORKER-P4B

The `save_parallel_report_to_archive` function was recently refactored to not be `async` anymore.
However the `async_to_sync` wrapper was still doing its job, running the function in an async context on a background thread.

This has lead to an error inside that function which was also calling `async_to_sync` internally.

Fixes WORKER-P4B
@Swatinem Swatinem requested a review from a team September 2, 2024 13:42
@Swatinem Swatinem self-assigned this Sep 2, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   97.94%   98.06%   +0.12%     
==========================================
  Files         434      434              
  Lines       36627    36626       -1     
==========================================
+ Hits        35873    35919      +46     
+ Misses        754      707      -47     
Flag Coverage Δ
integration 98.06% <100.00%> (+0.12%) ⬆️
latest-uploader-overall 98.06% <100.00%> (+0.12%) ⬆️
unit 98.06% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (+0.31%) ⬆️
OutsideTasks 98.06% <ø> (+0.02%) ⬆️
Files Coverage Δ
tasks/upload_finisher.py 97.15% <100.00%> (+1.87%) ⬆️

... and 2 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (40bcec1) to head (06f625c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   97.94%   98.06%   +0.12%     
==========================================
  Files         434      434              
  Lines       36627    36626       -1     
==========================================
+ Hits        35873    35919      +46     
+ Misses        754      707      -47     
Flag Coverage Δ
integration 98.06% <100.00%> (+0.12%) ⬆️
latest-uploader-overall 98.06% <100.00%> (+0.12%) ⬆️
unit 98.06% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (+0.31%) ⬆️
OutsideTasks 98.06% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
tasks/upload_finisher.py 97.15% <100.00%> (+1.87%) ⬆️

... and 2 files with indirect coverage changes

Copy link

codecov-public-qa bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (40bcec1) to head (06f625c).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   97.94%   98.06%   +0.12%     
==========================================
  Files         434      434              
  Lines       36627    36626       -1     
==========================================
+ Hits        35873    35919      +46     
+ Misses        754      707      -47     
Flag Coverage Δ
integration 98.06% <100.00%> (+0.12%) ⬆️
latest-uploader-overall 98.06% <100.00%> (+0.12%) ⬆️
unit 98.06% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <100.00%> (+0.31%) ⬆️
OutsideTasks 98.06% <ø> (+0.02%) ⬆️
Files Coverage Δ
tasks/upload_finisher.py 97.15% <100.00%> (+1.87%) ⬆️

... and 2 files with indirect coverage changes

@Swatinem Swatinem added this pull request to the merge queue Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (40bcec1) to head (06f625c).
Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   97.99%   98.11%   +0.12%     
==========================================
  Files         474      474              
  Lines       37953    37952       -1     
==========================================
+ Hits        37191    37237      +46     
+ Misses        762      715      -47     
Flag Coverage Δ
integration 98.06% <100.00%> (+0.12%) ⬆️
latest-uploader-overall 98.06% <100.00%> (+0.12%) ⬆️
unit 98.06% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.05% <100.00%> (+0.30%) ⬆️
OutsideTasks 98.06% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
tasks/upload_finisher.py 97.16% <100.00%> (+1.86%) ⬆️

... and 2 files with indirect coverage changes

This change has been scanned for critical changes. Learn more

Merged via the queue into main with commit f8f4c0a Sep 2, 2024
25 of 26 checks passed
@Swatinem Swatinem deleted the swatinem/fix-double-async branch September 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants