Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double-async_to_sync #672

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Remove double-async_to_sync #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tasks/upload_finisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from concurrent.futures import ThreadPoolExecutor
from enum import Enum

from asgiref.sync import async_to_sync
from redis.exceptions import LockError
from shared.celery_config import (
compute_comparison_task_name,
Expand Down Expand Up @@ -170,9 +169,9 @@ def run_impl(
)

with metrics.timer(f"{self.metrics_prefix}.save_parallel_report_results"):
parallel_paths = async_to_sync(
report_service.save_parallel_report_to_archive
)(commit, report, report_code)
parallel_paths = report_service.save_parallel_report_to_archive(
commit, report, report_code
)
# now that we've built the report and stored it to GCS, we have what we need to
# compare the results with the current upload pipeline. We end execution of the
# finisher task here so that we don't cause any additional side-effects
Expand Down
Loading