Do not update Commit.notified
#860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
==========================================
- Coverage 97.97% 97.96% -0.02%
==========================================
Files 442 442
Lines 35672 35641 -31
==========================================
- Hits 34949 34915 -34
- Misses 723 726 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #860 +/- ##
==========================================
- Coverage 97.97% 97.96% -0.02%
==========================================
Files 442 442
Lines 35672 35641 -31
==========================================
- Hits 34949 34915 -34
- Misses 723 726 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #860 +/- ##
==========================================
- Coverage 97.97% 97.96% -0.02%
==========================================
Files 442 442
Lines 35672 35641 -31
==========================================
- Hits 34949 34915 -34
- Misses 723 726 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #860 +/- ##
==========================================
- Coverage 97.97% 97.96% -0.02%
==========================================
Files 442 442
Lines 35672 35641 -31
==========================================
- Hits 34949 34915 -34
- Misses 723 726 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Swatinem
force-pushed
the
swatinem/no-commit-notified
branch
2 times, most recently
from
aebfd73 to
3402d59
Compare
This field is constantly being updated/touched in both `UploadFinisher` and `Notify`. But I couldn’t find any piece of code that actually reads this field across the whole codebase.
Swatinem
force-pushed
the
swatinem/no-commit-notified
branch
from
3402d59 to
134feb9
Compare
This already happens as part of `{PreProcess,}Upload`, so it is not needed to set this field once again.
Swatinem
force-pushed
the
swatinem/no-commit-notified
branch
from
134feb9 to
eb9a68f
Compare
adrian-codecov
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is constantly being updated/touched in both
UploadFinisherandNotify.But I couldn’t find any piece of code that actually reads this field across the whole codebase.
Moves and debounces the update to
Repository.updatestamp, fixes https://github.com/codecov/internal-issues/issues/1043Stops setting
Commit.pullidinUploadFinisher.This already happens as part of
{PreProcess,}Upload, so it is not needed to set this field once again.This also cleans up the code quite a bit.
Part of codecov/engineering-team#2824