Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update Commit.notified #860

Merged
merged 3 commits into from
Nov 8, 2024

Stop setting `Commit.pullid` in `UploadFinisher`

eb9a68f
Select commit
Loading
Failed to load commit list.
Merged

Do not update Commit.notified #860

Stop setting `Commit.pullid` in `UploadFinisher`
eb9a68f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 8, 2024 in 0s

97.96% (-0.02%) compared to 9d6bdc7, passed because coverage increased by 0% when compared to adjusted base (97.96%)

View this Pull Request on Codecov

97.96% (-0.02%) compared to 9d6bdc7, passed because coverage increased by 0% when compared to adjusted base (97.96%)

Details

Codecov Report

Attention: Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.96%. Comparing base (9d6bdc7) to head (eb9a68f).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/upload_finisher.py 91.66% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   97.97%   97.96%   -0.02%     
==========================================
  Files         442      442              
  Lines       35672    35641      -31     
==========================================
- Hits        34949    34915      -34     
- Misses        723      726       +3     
Components Coverage Δ
NonTestCode 95.99% <91.89%> (-0.03%) ⬇️
OutsideTasks 97.98% <ø> (ø)
Files with missing lines Coverage Δ
tasks/notify.py 96.12% <ø> (-0.03%) ⬇️
tasks/tests/unit/test_notify_task.py 100.00% <ø> (ø)
tasks/tests/unit/test_upload_finisher_task.py 100.00% <100.00%> (ø)
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
tasks/tests/utils.py 100.00% <ø> (ø)
tasks/upload_processor.py 92.00% <100.00%> (-4.88%) ⬇️
tasks/upload_finisher.py 95.90% <91.66%> (-0.99%) ⬇️