day 2 lab complete passing tests no lint issues #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broxsonl
reviewed
Feb 15, 2017
| @@ -0,0 +1,117 @@ | |||
| # Created by https://www.gitignore.io/api/node,vim,osx,macos,linux | |||
|
|
|||
| *node_modules | |||
There was a problem hiding this comment.
Nice work ignoring your node modules folder.
| const eslint = require('gulp-eslint'); | ||
| const mocha = require('gulp-mocha'); | ||
|
|
||
| gulp.task('test', function(){ |
|
|
||
| gulp.task('test', function(){ | ||
| gulp.src('./test/*-test.js', {read: false}) | ||
| .pipe(mocha({reporter:'nyan'})); |
| gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']); | ||
| }); | ||
|
|
||
| gulp.task('default', ['dev']); |
There was a problem hiding this comment.
Good use of the default gulp task here running everything else!
|
|
||
| const greet = require('./lib/greet.js'); | ||
|
|
||
| greet.sayHello('Brian'); |
| "keywords": [], | ||
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { |
| const expect = require('chai').expect; | ||
|
|
||
| describe('Greet Module', function(){ | ||
| describe('#sayHello', function(){ |
There was a problem hiding this comment.
Nice work naming the method with the # before the name of the method.
| describe('Greet Module', function(){ | ||
| describe('#sayHello', function(){ | ||
| it('should return a string of hey name', function(){ | ||
| var result = greet.sayHello('brian'); |
There was a problem hiding this comment.
Good work storing the value of the method call in a variable to more cleanly reference it in your test below!
| expect(result).to.throw(Error); | ||
| }); | ||
| }); | ||
| describe('#sayGoodBye', function(){ |
| }); | ||
| it('should throw a missing name error', function(){ | ||
| var result = greet.sayHello; | ||
| expect(result).to.throw(Error); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.