Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions lab-brian/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": [ "error", "single" ],
"semi": ["error", "always"],
"linebreak-style": [ "error", "unix" ]
},
"env": {
"es6": true,
"node": true,
"mocha": true,
"jasmine": true
},
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true,
"impliedStrict": true
},
"extends": "eslint:recommended"
}
117 changes: 117 additions & 0 deletions lab-brian/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
# Created by https://www.gitignore.io/api/node,vim,osx,macos,linux

*node_modules

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ignoring your node modules folder.


### Node ###
# Logs
logs
*.log
npm-debug.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules
jspm_packages

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity



### Vim ###
# swap
[._]*.s[a-v][a-z]
[._]*.sw[a-p]
[._]s[a-v][a-z]
[._]sw[a-p]
# session
Session.vim
# temporary
.netrwhist
*~
# auto-generated tag files
tags


### OSX ###
*.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon
# Thumbnails
._*
# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent
# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk


### macOS ###
# Icon must end with two \r
# Thumbnails
# Files that might appear in the root of a volume
# Directories potentially created on remote AFP share


### Linux ###

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*

# End of https://www.gitignore.io/api/node,vim,osx,macos,linux
23 changes: 23 additions & 0 deletions lab-brian/gulpfile.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
'use strict';

const gulp = require('gulp');
const eslint = require('gulp-eslint');
const mocha = require('gulp-mocha');

gulp.task('test', function(){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good gulp task!

gulp.src('./test/*-test.js', {read: false})
.pipe(mocha({reporter:'nyan'}));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeeeeaaahhhh! Nyan Cat ftw!

});

gulp.task('lint', function(){
return gulp.src(['**/*.js', '!node_modules/**'])
.pipe(eslint())
.pipe(eslint.format())
.pipe(eslint.failAfterError());
});

gulp.task('dev', function(){
gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']);
});

gulp.task('default', ['dev']);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of the default gulp task here running everything else!

7 changes: 7 additions & 0 deletions lab-brian/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
'use strict';

const greet = require('./lib/greet.js');

greet.sayHello('Brian');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good modularized pattern. :)


greet.sayGoodBye();
12 changes: 12 additions & 0 deletions lab-brian/lib/greet.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict';

module.exports = exports = {};

exports.sayHello = function(name) {
if(arguments.length === 0) throw new Error('Name not provided');
return `hey ${name}`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good string interpolation. Awesome to get used to.

};

exports.sayGoodBye = function(){
return 'see you soon baboon';
};
19 changes: 19 additions & 0 deletions lab-brian/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"name": "lab-brian",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good dev dependencies.

"chai": "^3.5.0",
"gulp": "^3.9.1",
"gulp-eslint": "^3.0.1",
"gulp-mocha": "^3.0.1",
"mocha": "^3.2.0"
}
}
24 changes: 24 additions & 0 deletions lab-brian/test/greet-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
'use strict';

const greet = require('../lib/greet.js');
const expect = require('chai').expect;

describe('Greet Module', function(){
describe('#sayHello', function(){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work naming the method with the # before the name of the method.

it('should return a string of hey name', function(){
var result = greet.sayHello('brian');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work storing the value of the method call in a variable to more cleanly reference it in your test below!

expect(greet).to.have.property('sayHello');
expect(result).to.equal('hey brian');
});
it('should throw a missing name error', function(){
var result = greet.sayHello;
expect(result).to.throw(Error);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice using the .to.throw syntax!

});
});
describe('#sayGoodBye', function(){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great testing. :)

it('should return see you soon baboon', function(){
var result = greet.sayGoodBye();
expect(result).to.equal('see you soon baboon');
});
});
});