file process #1
Open
file process #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broxsonl
reviewed
Feb 16, 2017
| "indent": [ "error", 2 ], | ||
| "quotes": [ "error", "single" ], | ||
| "semi": ["error", "always"], | ||
| "linebreak-style": [ "error", "unix" ] |
| @@ -0,0 +1,127 @@ | |||
| # Created by https://www.gitignore.io/api/node,vim,macos,linux,windows | |||
|
|
|||
| node_modules/ | |||
| @@ -0,0 +1 @@ | |||
| The words in the one file | |||
There was a problem hiding this comment.
This SHOULD output different buffers when you read these, but it could be a problem that all 3 of your txt files have the same first 16 characters.
|
|
||
| const fs = require('fs'); | ||
|
|
||
| const readFile = module.exports = function(file, callback) { |
There was a problem hiding this comment.
Your function needs to be able to take in all 3 files at once and read them asynchronously.
Currently, this function can only take a single file and read it.
|
|
||
| describe('inproper file path', function(){ | ||
| it('should return an error', function(done) { | ||
| readFile(`${__dirname}/fake-file.txt`, function(err){ |
| }); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Need a test to be able to read all 3 files asynchronously and return a value only if all 3 work successfully.
Currently, you do not have the logic for reading all 3 within one function call, which is an assignment requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.