Skip to content

file process #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions lab-khalid/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": [ "error", "single" ],
"semi": ["error", "always"],
"linebreak-style": [ "error", "unix" ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comma dangle. :p Boo.

},
"env": {
"es6": true,
"node": true,
"mocha": true,
"jasmine": true
},
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true,
"impliedStrict": true
},
"extends": "eslint:recommended"
}
127 changes: 127 additions & 0 deletions lab-khalid/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
# Created by https://www.gitignore.io/api/node,vim,macos,linux,windows

node_modules/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job ignoring node_modules.


### Node ###
# Logs
logs
*.log
npm-debug.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules
jspm_packages

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity



### Vim ###
# swap
[._]*.s[a-w][a-z]
[._]s[a-w][a-z]
# session
Session.vim
# temporary
.netrwhist
*~
# auto-generated tag files
tags


### macOS ###
*.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon
# Thumbnails
._*
# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent
# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk


### Linux ###

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*


### Windows ###
# Windows image file caches
Thumbs.db
ehthumbs.db

# Folder config file
Desktop.ini

# Recycle Bin used on file shares
$RECYCLE.BIN/

# Windows Installer files
*.cab
*.msi
*.msm
*.msp

# Windows shortcuts
*.lnk
1 change: 1 addition & 0 deletions lab-khalid/data/one.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The words in the one file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SHOULD output different buffers when you read these, but it could be a problem that all 3 of your txt files have the same first 16 characters.

1 change: 1 addition & 0 deletions lab-khalid/data/three.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The words in the three file
1 change: 1 addition & 0 deletions lab-khalid/data/two.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The words in the two file
Empty file added lab-khalid/index.js
Empty file.
11 changes: 11 additions & 0 deletions lab-khalid/lib/read-file.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
'use strict';

const fs = require('fs');

const readFile = module.exports = function(file, callback) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your function needs to be able to take in all 3 files at once and read them asynchronously.

Currently, this function can only take a single file and read it.

fs.readFile(file, function(err, data) {
if(err) throw callback(err);
console.log(data.toString('hex', 0, 8));
return callback(null, data.toString());
});
};
19 changes: 19 additions & 0 deletions lab-khalid/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"name": "lab-khalid",
"version": "1.0.0",
"description": "",
"main": "index.js",
"directories": {
"test": "test"
},
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"chai": "^3.5.0",
"mocha": "^3.2.0"
}
}
50 changes: 50 additions & 0 deletions lab-khalid/test/data-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
'use strict';

const expect = require('chai').expect;
const readFile = require('../lib/read-file.js');

describe('Reading the data files', function(){

describe('inproper file path', function(){
it('should return an error', function(done) {
readFile(`${__dirname}/fake-file.txt`, function(err){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test for a bad filepath.

expect(err).to.be.an('error');
done();
});
});
});

describe('one.txt', function() {
it('should return content from one.txt', function(done) {
readFile(`${__dirname}/../data/one.txt`, function(err, data) {
expect(err).to.equal(null);
expect(data).to.be.a('string');
expect(data).to.be.equal('The words in the one file\n')
done();
});
});
});

describe('two.txt', function(){
it('should return content from two.txt', function(done){
readFile(`${__dirname}/../data/two.txt`, function(err, data){
expect(err).to.equal(null);
expect(data).to.be.a('string');
expect(data).to.be.equal('The words in the two file\n')
done();
});
});
});

describe('three.txt', function() {
it('should return the content from three.txt', function(done){
readFile(`${__dirname}/../data/three.txt`, function(err, data){
expect(err).to.equal(null);
expect(data).to.be.a('string');
expect(data).to.be.equal('The words in the three file\n')
done();
});
});
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a test to be able to read all 3 files asynchronously and return a value only if all 3 work successfully.

Currently, you do not have the logic for reading all 3 within one function call, which is an assignment requirement.

});