Skip to content

Commit

Permalink
Issue #308 Android bug fixes (#311)
Browse files Browse the repository at this point in the history
* Replace TouchableOpacity with View

This TouchableOpacity does not appear to be doing anything, and we think it may be causing accessibility warnings in the Android pre-launch tests, since it does not have accessibility attributes.  It seems safe to make it a View instead.

* Android bug fixes
* Attempt to resolve camera permissions error by adding android permission "READ_EXTERNAL_STORAGE"
* Resolve error when deleting a plog which has a photo attached by adding delete permission to storage rules

Co-authored-by: B. Sanders <bdougsand+cfb@gmail.com>
Co-authored-by: Ben Lewis <ben.lewis@neuralshunt.com>
Co-authored-by: VA Kenyon <ValerieKenyon@users.noreply.github.com>

Co-authored-by: B. Sanders <bdougsand+cfb@gmail.com>
Co-authored-by: Ben Lewis <ben.lewis@neuralshunt.com>
Co-authored-by: VA Kenyon <ValerieKenyon@users.noreply.github.com>
  • Loading branch information
4 people authored Apr 6, 2021
1 parent e4f4720 commit 8de8793
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export default ({config}) => {
"package": androidBundleIdentifier,
"googleServicesFile": googleServicesJson,
// "softwareKeyboardLayoutMode": "pan",
"permissions": ["CAMERA", "CAMERA_ROLL", "ACCESS_FINE_LOCATION"],
"permissions": ["CAMERA", "CAMERA_ROLL", "ACCESS_FINE_LOCATION", "READ_EXTERNAL_STORAGE"],
"versionCode": 7,
"intentFilters": [
{
Expand Down
1 change: 1 addition & 0 deletions firebase/project/storage.rules
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ service firebase.storage {
allow write: if isUploadAllowed()
&& n.matches("[0-9]\\.jpg");
allow read: if isPublic() || isOwner();
allow delete: if isOwner();
}

match /plog/profile.jpg {
Expand Down

0 comments on commit 8de8793

Please sign in to comment.