Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #308 Android bug fixes #311

Merged
merged 4 commits into from
Apr 6, 2021
Merged

Conversation

ShepherdBook
Copy link
Contributor

Hack night 3/30/21

  • Attempt to resolve camera permissions error by adding android permission "READ_EXTERNAL_STORAGE"
  • Resolve error when deleting a plog which has a photo attached by adding delete permission to storage rules

Zach Johnston and others added 4 commits February 16, 2021 21:24
This TouchableOpacity does not appear to be doing anything, and we think it may be causing accessibility warnings in the Android pre-launch tests, since it does not have accessibility attributes.  It seems safe to make it a View instead.
* Attempt to resolve camera permissions error by adding android permission "READ_EXTERNAL_STORAGE"
* Resolve error when deleting a plog which has a photo attached by adding delete permission to storage rules

Co-authored-by: B. Sanders <bdougsand+cfb@gmail.com>
Co-authored-by: Ben Lewis <ben.lewis@neuralshunt.com>
Co-authored-by: VA Kenyon <ValerieKenyon@users.noreply.github.com>
@bdougsand bdougsand merged commit 8de8793 into codeforboston:develop Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants