Merge pull request #8175 from kenjis/refactor-param-types

refactor: fix param types
codeigniter4 · Nov 20, 2023 · 0153a66 · 0153a66
2 parents c4dba01 + c91de98
commit 0153a66
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/system/CLI/CLI.php b/system/CLI/CLI.php
@@ -256,7 +256,7 @@ public static function prompt(string $field, $options = null, $validation = null
  static::fwrite(STDOUT, $field . (trim($field) ? ' ' : '') . $extraOutput . ': ');
 
  // Read the input from keyboard.
- $input = trim(static::$io->input()) ?: $default;
+ $input = trim(static::$io->input()) ?: (string) $default;
 
  if ($validation !== []) {
  while (! static::validate('"' . trim($field) . '"', $input, $validation)) {

diff --git a/system/Commands/Database/MigrateStatus.php b/system/Commands/Database/MigrateStatus.php
@@ -127,7 +127,7 @@ public function run(array $params)
  continue;
  }
 
- $date = date('Y-m-d H:i:s', $row->time);
+ $date = date('Y-m-d H:i:s', (int) $row->time);
  $group = $row->group;
  $batch = $row->batch;
  // @codeCoverageIgnoreEnd

diff --git a/tests/system/Models/InsertModelTest.php b/tests/system/Models/InsertModelTest.php
@@ -120,7 +120,7 @@ public function testInsertBatchSetsIntTimestamps(): void
  $this->assertSame(2, $this->model->insertBatch($jobData));
 
  $result = $this->model->where('name', 'Philosopher')->first();
- $this->assertCloseEnough(time(), $result->created_at);
+ $this->assertCloseEnough(time(), (int) $result->created_at);
  }
 
  public function testInsertBatchSetsDatetimeTimestamps(): void