Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix param types #8175

Merged
merged 2 commits into from
Nov 20, 2023
Merged

refactor: fix param types #8175

merged 2 commits into from
Nov 20, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 8, 2023 •
edited
Loading

Description

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Nov 8, 2023
@kenjis kenjis mentioned this pull request Nov 8, 2023
Merged
5 tasks
@kenjis
Copy link
Member Author

kenjis commented Nov 9, 2023

Psalm error is not related to this PR.

@kenjis kenjis merged commit 0153a66 into codeigniter4:4.5 Nov 20, 2023
45 checks passed
@kenjis kenjis deleted the refactor-param-types branch November 20, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.5 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner