Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing Migration lang item #5557

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 9, 2022

Description

  • add missing Migration lang item
$ php spark migrate

CodeIgniter v4.1.6 Command Line Tool - Server Time: 2022-01-08 20:30:40 UTC-06:00

すべての新しいマイグレーションを実行しています...
Done migrations.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 9, 2022
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small semantic suggestion.

@lonnieezell do we need to do anything to "request translators" when new strings get added, for the translations repo?

system/Commands/Database/Migrate.php Outdated Show resolved Hide resolved
system/Language/en/Migrations.php Outdated Show resolved Hide resolved
@sfadschm
Copy link
Contributor

sfadschm commented Jan 9, 2022

Small semantic suggestion.

@lonnieezell do we need to do anything to "request translators" when new strings get added, for the translations repo?

Paul implemented static analysis checks in the translation repo that check for missing, duplicated or copied strings.

kenjis and others added 2 commits January 10, 2022 08:37
Co-authored-by: MGatner <mgatner@icloud.com>
Co-authored-by: MGatner <mgatner@icloud.com>
@kenjis
Copy link
Member Author

kenjis commented Jan 9, 2022

Paul implemented static analysis checks in the translation repo that check for missing, duplicated or copied strings.

But translators do not know if they run checks.

@kenjis kenjis requested a review from MGatner January 10, 2022 06:35
@kenjis kenjis merged commit d531506 into codeigniter4:develop Jan 10, 2022
@kenjis kenjis deleted the add-migration-lang branch January 10, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants