Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing Migration lang item #5557

Merged
merged 4 commits into from
Jan 10, 2022
Merged

fix: add missing Migration lang item #5557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
867e8d6
fix: add missing Migration lang item
kenjis Jan 9, 2022
ceff4d7
refactor: fix lang key
kenjis Jan 9, 2022
41c8b17
refactor: fix lang key
kenjis Jan 9, 2022
1abcac3
test: update migration message
kenjis Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/Commands/Database/Migrate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function run(array $params)
CLI::write($message);
}

CLI::write('Done migrations.', 'green');
CLI::write(lang('Migrations.migrated'), 'green');

// @codeCoverageIgnoreStart
} catch (Throwable $e) {
Expand Down
1 change: 1 addition & 0 deletions system/Language/en/Migrations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@

'latest' => 'Running all new migrations...',
'generalFault' => 'Migration failed!',
'migrated' => 'Migrations complete.',
'migInvalidVersion' => 'Invalid version number provided.',
'toVersionPH' => 'Migrating to version %s...',
'toVersion' => 'Migrating to current version...',
Expand Down
6 changes: 3 additions & 3 deletions tests/system/Commands/DatabaseCommandsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ protected function clearBuffer(): void
public function testMigrate()
{
command('migrate --all');
$this->assertStringContainsString('Done migrations.', $this->getBuffer());
$this->assertStringContainsString('Migrations complete.', $this->getBuffer());
command('migrate:rollback');

$this->clearBuffer();
command('migrate -n Tests\\\\Support');
$this->assertStringContainsString('Done migrations.', $this->getBuffer());
$this->assertStringContainsString('Migrations complete.', $this->getBuffer());
}

public function testMigrateRollback()
Expand All @@ -75,7 +75,7 @@ public function testMigrateRefresh()
$this->clearBuffer();

command('migrate:refresh');
$this->assertStringContainsString('Done migrations.', $this->getBuffer());
$this->assertStringContainsString('Migrations complete.', $this->getBuffer());
}

public function testMigrateStatus()
Expand Down