Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug that allows dynamic controllers to be used #5814

Merged
merged 6 commits into from
Mar 22, 2022
Merged

fix: bug that allows dynamic controllers to be used #5814

merged 6 commits into from
Mar 22, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 20, 2022

Description
Dynamic controllers are not allowed for security reasons. See #2787 (comment)
But there is a bug that allows dynamic controllers.

  • add check for dynamic controllers
  • refactor

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
refactor: rename variable names
8aa0a1e
@kenjis
docs: remove comments
bb6f480 
I don't understand what's saying.
@kenjis
test: fix route key
44d68fa 
All lowercase is better.
@kenjis
test: remove empty tearDown()
53ac90a
@kenjis
refactor: make if conditions a bit easier to read
98fdcb9
@kenjis
fix: add check for dynamic controller
46401c2 
Dynamic controller should not be used, but if you set a route like this, it worked.
$routes->get('(:segment)/(:segment)/(:segment)', '\App\Controllers\\\\$2::$3');
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 20, 2022
MGatner
MGatner approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting out the commits, made it much easier to find the actual fix. Looks good!

@kenjis kenjis merged commit 8c1c5c9 into codeigniter4:develop Mar 22, 2022
@kenjis kenjis deleted the fix-dynamic-controllers branch March 22, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner