Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug that allows dynamic controllers to be used #5814

Merged
merged 6 commits into from
Mar 22, 2022
Merged

fix: bug that allows dynamic controllers to be used #5814

merged 6 commits into from
Mar 22, 2022

Commits on Mar 20, 2022

  1. refactor: rename variable names

    @kenjis
    kenjis committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    8aa0a1e View commit details
    Browse the repository at this point in the history

  2. docs: remove comments 

    I don't understand what's saying.
    @kenjis
    kenjis committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    bb6f480 View commit details
    Browse the repository at this point in the history

  3. test: fix route key 

    All lowercase is better.
    @kenjis
    kenjis committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    44d68fa View commit details
    Browse the repository at this point in the history

  4. test: remove empty tearDown()

    @kenjis
    kenjis committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    53ac90a View commit details
    Browse the repository at this point in the history

  5. refactor: make if conditions a bit easier to read

    @kenjis
    kenjis committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    98fdcb9 View commit details
    Browse the repository at this point in the history

  6. fix: add check for dynamic controller 

    Dynamic controller should not be used, but if you set a route like this, it worked.
$routes->get('(:segment)/(:segment)/(:segment)', '\App\Controllers\\\\$2::$3');
    @kenjis
    kenjis committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    46401c2 View commit details
    Browse the repository at this point in the history