fix: CodeIgniter::run() doesn't respect $returnResponse #6737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
kenjis
changed the title
samsonasik
reviewed
Oct 22, 2022
samsonasik
reviewed
Oct 22, 2022
samsonasik
reviewed
Oct 22, 2022
kenjis
commented
Oct 23, 2022
| if ($this->returnRespose) { | ||
| return $this->response; | ||
| } | ||
|
|
||
| $this->sendResponse(); | ||
|
|
||
| $this->callExit(EXIT_SUCCESS); |
There was a problem hiding this comment.
Not related to this PR, but is this callExit() necessary?
There was a problem hiding this comment.
I'm not sure - maybe just to enforce a "never return" condition?
There was a problem hiding this comment.
If you will add @phpstan-return never to protected function callExit, then phpstan correctly flags that the return; below will not be reached. So, this must be a bug?
There was a problem hiding this comment.
I think the return is there because MockCodeIgniter prevents the actual exit statement. Still, this is a bad set up, and we should probably get rid of the exit altogether and just have the whole stack return cleanly.
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
kenjis
force-pushed
the
fix-CodeIgniter-run-returnResponse
branch
from
54b9d3a
to
59c076f
Compare
MGatner
reviewed
Oct 23, 2022
MGatner
approved these changes
Oct 24, 2022
michalsn
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6650
Checklist: