fix: [SQLite3] Forge::modifyColumn() messes up table

[kenjis]

Description
Fixes #8410

OCI8 test failure will be fixed in #8459

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

@dgvirtual Can you test this?

[dgvirtual]

@dgvirtual Can you test this?

I would like to. How do I pull the changes into the code on my machine, what should I google for to find how its done? sth like this?

[kenjis]

@dgvirtual If you like CLI, I recommend https://cli.github.com/

gh pr checkout 8457

Of course you can get from my repository:
https://github.com/kenjis/CodeIgniter4/tree/fix-sqlite3-modifyColumn

[dgvirtual]

Hi, so I rerun the routine that I applied when filing bug report #8410.

There is still one unrequested change that happens in an unreleated column, and I am not sure how bad it is; default of column with TINYINT datatype changes from integer zero to string zero:

+----------------+----------+-------------+----------+---------+-------------+
|  Field Name      | Type       | Max Length | Nullable  | Default  | Primary Key |
+----------------+----------+-------------+----------+---------+-------------+
before:
| paid                 | TINYINT  |                     | No           | 0            | No               |
after (note col Default): 
| paid                | TINYINT  |                      | No           | '0'          | No               |

Same happens if I change the type to INT or DECIMAL.

[kenjis]

@dgvirtual Thank you for testing.
I've fixed.

Before modifyColumn():

CREATE TABLE `db_invoices` (
	`id` INTEGER PRIMARY KEY AUTOINCREMENT,
	`user_id` INT NOT NULL,
	`month` VARCHAR NOT NULL,
	`invoice_series` VARCHAR NOT NULL,
	`total` DECIMAL NOT NULL,
	`paid` TINYINT NOT NULL DEFAULT 0,
	`paid_date` VARCHAR NULL DEFAULT NULL,
	`created_at` DATETIME NOT NULL,
	`updated_at` DATETIME NOT NULL
)

After modifyColumn():

CREATE TABLE `db_invoices` (
	`id` INTEGER NULL,
	`user_id` INT NOT NULL,
	`month` VARCHAR NOT NULL,
	`series` VARCHAR NOT NULL,
	`total` DECIMAL NOT NULL,
	`paid` TINYINT NOT NULL DEFAULT 0,
	`paid_date` VARCHAR NULL DEFAULT NULL,
	`created_at` DATETIME NOT NULL,
	`updated_at` DATETIME NOT NULL,
	CONSTRAINT `pk_db_invoices` PRIMARY KEY(`id`)
)