Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [OCI8] getFieldData() returns incorrect default value #8459

Merged
merged 4 commits into from
Jan 30, 2024
Merged

fix: [OCI8] getFieldData() returns incorrect default value #8459

merged 4 commits into from
Jan 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 26, 2024 •
edited
Loading

Description

  • fix a bug that returns '' instead of null

Found in #8457
https://github.com/codeigniter4/CodeIgniter4/actions/runs/7664355802/job/20888609701?pr=8457

1) CodeIgniter\Database\Live\ForgeTest::testModifyColumnRename
Failed asserting that '' is null.

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/Live/ForgeTest.php:1339
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:106

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jan 26, 2024
@kenjis kenjis mentioned this pull request Jan 26, 2024
Merged
5 tasks
@kenjis kenjis merged commit 8fc9503 into codeigniter4:develop Jan 30, 2024
62 checks passed
@kenjis kenjis deleted the fix-oci8-getFieldData-default branch January 30, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn