Skip to content

test: refactor GetFieldDataTest #8480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 31, 2024
Merged

test: refactor GetFieldDataTest #8480

merged 5 commits into from
Jan 31, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 30, 2024 •
edited
Loading

Needs #8481

Description

  • refactor to add another test

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Jan 30, 2024
@kenjis kenjis force-pushed the test-refactor-getFieldData branch 3 times, most recently from cb06062 to 1cd8bcd Compare January 30, 2024 02:31
@kenjis kenjis marked this pull request as draft January 30, 2024 05:19
@kenjis kenjis force-pushed the test-refactor-getFieldData branch 3 times, most recently from 113c0f5 to f3fd479 Compare January 30, 2024 07:25
@kenjis kenjis mentioned this pull request Jan 30, 2024
Merged
5 tasks
@kenjis kenjis force-pushed the test-refactor-getFieldData branch from f3fd479 to c271e1f Compare January 31, 2024 00:21
@kenjis kenjis marked this pull request as ready for review January 31, 2024 00:22
@kenjis kenjis merged commit 6607f15 into codeigniter4:develop Jan 31, 2024
@kenjis kenjis deleted the test-refactor-getFieldData branch January 31, 2024 23:57
@kenjis kenjis added the refactor Pull requests that refactor code label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn