Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [OCI8][Postgre][SQLSRV][SQLite3] change order of properties returned by getFieldData() #8481

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix: [OCI8][Postgre][SQLSRV][SQLite3] change order of properties returned by getFieldData() #8481

merged 1 commit into from
Jan 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 30, 2024 •
edited
Loading

Description
Change the order of properties in the stdClass object returned by getFieldData() to the same for all DB drivers.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jan 30, 2024
@kenjis kenjis force-pushed the fix-getFieldData-property-order branch from e070750 to db4b7c5 Compare January 30, 2024 04:05
@kenjis kenjis changed the title fix: change order of properties returned by getFieldData() fix: [OCI8][Postgre][SQLSRV][SQLite3] change order of properties returned by getFieldData() Jan 30, 2024
@kenjis kenjis force-pushed the fix-getFieldData-property-order branch 3 times, most recently from f30768f to f50e02c Compare January 30, 2024 04:46
@kenjis kenjis force-pushed the fix-getFieldData-property-order branch from f50e02c to aa6978e Compare January 30, 2024 05:18
@kenjis kenjis mentioned this pull request Jan 30, 2024
Merged
5 tasks
@kenjis kenjis merged commit 65c6692 into codeigniter4:develop Jan 30, 2024
63 checks passed
@kenjis kenjis deleted the fix-getFieldData-property-order branch January 30, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn