Skip to content

feat: add "400 Bad Request" page for end users #9044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2024
Merged

feat: add "400 Bad Request" page for end users #9044

merged 3 commits into from
Jul 19, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 11, 2024 •
edited
Loading

Description

  • add 400 page

Before:
production
Screenshot 2024-07-11 10 34 16
After:
production
Screenshot 2024-07-11 10 33 20
development
Screenshot 2024-07-11 10 32 55

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.6 enhancement PRs that improve existing functionalities labels Jul 11, 2024
@luckmoshy
Copy link

luckmoshy commented Jul 11, 2024 •
edited
Loading

yeah exactly, this is what I wanted, no exceptions in the production environment

@kenjis @paulbalandan
docs: fix by proofreading
1e06ee5 
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
@kenjis kenjis merged commit e469021 into codeigniter4:4.6 Jul 19, 2024
42 checks passed
@kenjis kenjis deleted the feat-add-400-page branch July 19, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan left review comments

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @luckmoshy @michalsn @paulbalandan