Skip to content

feat: add "400 Bad Request" page for end users #9044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2024
Merged

feat: add "400 Bad Request" page for end users #9044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b235d0
feat: add page for 400 request
kenjis Jul 11, 2024
d758faf
docs: add user guide
kenjis Jul 12, 2024
1e06ee5
docs: fix by proofreading
kenjis Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions app/Views/errors/html/error_400.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title><?= lang('Errors.badRequest') ?></title>

<style>
div.logo {
height: 200px;
width: 155px;
display: inline-block;
opacity: 0.08;
position: absolute;
top: 2rem;
left: 50%;
margin-left: -73px;
}
body {
height: 100%;
background: #fafafa;
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
color: #777;
font-weight: 300;
}
h1 {
font-weight: lighter;
letter-spacing: normal;
font-size: 3rem;
margin-top: 0;
margin-bottom: 0;
color: #222;
}
.wrap {
max-width: 1024px;
margin: 5rem auto;
padding: 2rem;
background: #fff;
text-align: center;
border: 1px solid #efefef;
border-radius: 0.5rem;
position: relative;
}
pre {
white-space: normal;
margin-top: 1.5rem;
}
code {
background: #fafafa;
border: 1px solid #efefef;
padding: 0.5rem 1rem;
border-radius: 5px;
display: block;
}
p {
margin-top: 1.5rem;
}
.footer {
margin-top: 2rem;
border-top: 1px solid #efefef;
padding: 1em 2em 0 2em;
font-size: 85%;
color: #999;
}
a:active,
a:link,
a:visited {
color: #dd4814;
}
</style>
</head>
<body>
<div class="wrap">
<h1>400</h1>

<p>
<?php if (ENVIRONMENT !== 'production') : ?>
<?= nl2br(esc($message)) ?>
<?php else : ?>
<?= lang('Errors.sorryBadRequest') ?>
<?php endif; ?>
</p>
</div>
</body>
</html>
2 changes: 2 additions & 0 deletions system/Language/en/Errors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
return [
'pageNotFound' => '404 - Page Not Found',
'sorryCannotFind' => 'Sorry! Cannot seem to find the page you were looking for.',
'badRequest' => '400 - Bad Request',
'sorryBadRequest' => 'Sorry! Something is wrong with your request.',
'whoops' => 'Whoops!',
'weHitASnag' => 'We seem to have hit a snag. Please try again later...',
];
2 changes: 2 additions & 0 deletions user_guide_src/source/changelogs/v4.6.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,14 @@ Others
arguments in before or after.
- **Services:** Added ``BaseService::resetServicesCache()`` method to reset
the services cache. See :ref:`resetting-services-cache`.
- **Errors:** Added a default error page for "400 Bad Request".

***************
Message Changes
***************

- Added ``Validation.min_dims`` message
- Added ``Errors.badRequest`` and ``Errors.sorryBadRequest``

*******
Changes
Expand Down
Loading