Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add $mailType with html value for email config #1019

Closed
wants to merge 1 commit into from

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Feb 8, 2024

Description
We use format html to send emails, so it's better to have this in the documentation.
see https://forum.codeigniter.com/showthread.php?tid=89321

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added the documentation Improvements or additions to documentation label Feb 8, 2024
@@ -124,6 +124,7 @@ your project.
{
public string $fromEmail = 'your_mail@example.com';
public string $fromName = 'your name';
public string $mailType = 'html';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the Config file to the CI4 application.
It is not sure that the dev uses HTML for all emails that s/he sends.

But Shield uses HTML mails, so should Shield send the mails as 'html' at the runtime?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent #1020

@kenjis kenjis deleted the datamweb-docs-improve branch February 13, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants