Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Shield may not send correct HTML mail #1020

Merged
merged 3 commits into from
Feb 13, 2024
Merged

fix: Shield may not send correct HTML mail #1020

merged 3 commits into from
Feb 13, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 8, 2024 •
edited by datamweb
Loading

Description
Closes #1018, Resolves #1019

  • fix emailer()
  • fix code that sends email

Before:
Screenshot 2024-02-08 13 15 06

After:
Screenshot 2024-02-08 13 14 58

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Something isn't working label Feb 8, 2024
@kenjis kenjis mentioned this pull request Feb 8, 2024
Closed
5 tasks
datamweb
datamweb approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks @kenjis.

@datamweb datamweb merged commit ce49903 into codeigniter4:develop Feb 13, 2024
38 checks passed
@kenjis kenjis deleted the fix-html-mail branch February 13, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev: update shield:setup command for set config/Emal::$mailType With html
2 participants
@kenjis @datamweb