Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: 4.0.1 #4678

Merged
merged 4 commits into from
Jan 5, 2022
Merged

release: 4.0.1 #4678

merged 4 commits into from
Jan 5, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 4, 2022 •
edited
Loading

This PR is to generate a new release of code-server at 4.0.1

Screenshot

Screen.Recording.2022-01-04.at.2.45.38.PM.mov

TODOs

Follow "Publishing a release" steps in ci/README.md

Fixes #4675

Notes

Found this issue and documented: #4679

@jsjoeio jsjoeio self-assigned this Jan 4, 2022
@jsjoeio jsjoeio requested a review from a team January 4, 2022 17:28
@github-actions
Copy link

github-actions bot commented Jan 4, 2022 •
edited
Loading

✨ Coder.com for PR #4678 deployed! It will be updated on every commit.

@jsjoeio jsjoeio modified the milestone: 4.0.1 Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022 •
edited
Loading

Codecov Report

Merging #4678 (735c6da) into main (3d99998) will not change coverage.
The diff coverage is n/a.

❗ Current head 735c6da differs from pull request most recent head 7fe23da. Consider uploading reports for the commit 7fe23da to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4678   +/-   ##
=======================================
  Coverage   69.10%   69.10%           
=======================================
  Files          29       29           
  Lines        1638     1638           
  Branches      341      341           
=======================================
  Hits         1132     1132           
  Misses        430      430           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d99998...7fe23da. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to CI January 4, 2022 18:37 Inactive
@jsjoeio jsjoeio temporarily deployed to CI January 4, 2022 20:11 Inactive
jsjoeio
jsjoeio commented Jan 4, 2022
View reviewed changes
ci/build/release-prep.sh
@@ -83,7 +83,7 @@ main() {
echo -e "Great! We'll prep a PR for updating to $CODE_SERVER_VERSION_TO_UPDATE\n"
$CMD rg -g '!yarn.lock' -g '!*.svg' -g '!CHANGELOG.md' --files-with-matches --fixed-strings "${CODE_SERVER_CURRENT_VERSION}" | $CMD xargs sd "$CODE_SERVER_CURRENT_VERSION" "$CODE_SERVER_VERSION_TO_UPDATE"

$CMD git commit -am "chore(release): bump version to $CODE_SERVER_VERSION_TO_UPDATE"
$CMD git commit --no-verify -am "chore(release): bump version to $CODE_SERVER_VERSION_TO_UPDATE"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Could be my machine but when I run this script, Husky/git precommit fails. Adding --no-verify here so there are no issues running the script.

ci/helm-chart/Chart.yaml
@@ -15,9 +15,9 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.0.5
version: 2.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⬆️ Bumping major versions since we bumped the major version of code-server

@jsjoeio jsjoeio temporarily deployed to CI January 4, 2022 20:34 Inactive
@jsjoeio jsjoeio marked this pull request as ready for review January 4, 2022 20:38
@jsjoeio jsjoeio temporarily deployed to CI January 4, 2022 21:05 Inactive
@benz0li
Copy link
Contributor

benz0li commented Jan 5, 2022

Please fix #3782 (comment) before releasing.

There is also #1510 (comment) which is in contradiction to #1510 (comment).

@jsjoeio jsjoeio marked this pull request as draft January 5, 2022 16:25
@jsjoeio jsjoeio temporarily deployed to CI January 5, 2022 17:35 Inactive
@jsjoeio jsjoeio marked this pull request as ready for review January 5, 2022 17:35
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 5, 2022

Tested again locally and all looks good!

Video

Screen.Recording.2022-01-05.at.1.02.38.PM.mov

@jsjoeio jsjoeio merged commit 484429b into main Jan 5, 2022
@jsjoeio jsjoeio deleted the v4.0.1 branch January 5, 2022 20:06
@jsjoeio jsjoeio restored the v4.0.1 branch January 5, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release: 4.0.1
3 participants
@jsjoeio @benz0li @code-asher