Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 7232 #7235

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Fix issue 7232 #7235

merged 1 commit into from
Mar 6, 2025

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Feb 27, 2025

@benz0li benz0li requested a review from a team as a code owner February 27, 2025 07:50
@benz0li
Copy link
Contributor Author

benz0li commented Mar 1, 2025

Ping @code-asher

@benz0li benz0li mentioned this pull request Mar 6, 2025
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! And sorry for the delay.

@code-asher code-asher merged commit 6f8493e into coder:main Mar 6, 2025
9 checks passed
@code-asher
Copy link
Member

code-asher commented Mar 6, 2025

Oh wait I already merged but had a thought, since we are grepping for 1000, is there any chance this matches extra things? Like maybe there is someuser:x:31000. Probably unlikely, but I wonder if we want to use getent passwd 1000 or something instead.

Also I wonder, if we already have a user 1000, could we rename it instead of delete/add?

Another thing I have not checked, if someone is using a different UID (-u 1002:1002 for example), maybe we should check for that instead of 1000. I forget exactly how the mapping works though, so maybe this is not necessary.

@benz0li
Copy link
Contributor Author

benz0li commented Mar 6, 2025

Oh wait I already merged but had a thought, since we are grepping for 1000, is there any chance this matches extra things? Like maybe there is someuser:x:31000. Probably unlikely, but I wonder if we want to use getent passwd 1000 or something instead.

Also I wonder, if we already have a user 1000, could we rename it instead of delete/add?

Yes. But this works just fine for both the official Debian and Ubuntu Docker Image.

@benz0li
Copy link
Contributor Author

benz0li commented Mar 6, 2025

Another thing I have not checked, if someone is using a different UID (-u 1002:1002 for example), maybe we should check for that instead of 1000. I forget exactly how the mapping works though, so maybe this is not necessary.

I have not checked that either.

@code-asher
Copy link
Member

Yes. But this works just fine for both the official Debian and Ubuntu Docker Image.

Fair. We can always revisit if we need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Ubuntu Noble docker image cannot start and prompts for sudo password for ubuntu user
2 participants