-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Code to 1.98.0 #7249
Update Code to 1.98.0 #7249
Conversation
When I try to build within a docker container using Node.js 18.20.1, it errors with
This also happens using a container with very few limits:
@code-asher Any idea why this happens? Does the build pipeline here run on a VM or in a container? Possibly related: |
With the following modification to 35c35
< "gulp": "node --max-old-space-size=8192 ./node_modules/gulp/bin/gulp.js",
---
> "gulp": "node ./node_modules/gulp/bin/gulp.js", Before removing, I set Build time: ~25 mins. Build log:
|
Functionality [modified by patches] tested and found to work:
Workspaces and Jupyter Notebooks also work fine:
|
@code-asher Could you review and merge too? |
It is erroring about needing a password, but also do we even need to run this as root considering we are not binding to privileged ports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
@benz0li, thanks for posting this fix! I also ran into this out-of-memory error when doing a build and tried doubling the heap size repeatedly. But removing the |
Fixes #7244