Skip to content

feat: pass through signals to inner container #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 1, 2025
Merged

feat: pass through signals to inner container #134

merged 6 commits into from
Apr 1, 2025

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Mar 31, 2025 •
edited
Loading

@sreya sreya requested a review from johnstcn March 31, 2025 04:06
@sreya
Copy link
Collaborator Author

sreya commented Mar 31, 2025

Tested it with an agent configured with a shutdown_script. Works as expected.

johnstcn
johnstcn approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Some comments below, but nothing blocking.

@sreya sreya merged commit fde2c32 into main Apr 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@sreya sreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent shutdown scripts are not run when envbox is terminated
2 participants
@sreya @johnstcn