Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent shutdown scripts are not run when envbox is terminated #76

Open
spikecurtis opened this issue Jun 24, 2024 · 0 comments · Fixed by #83
Open

Agent shutdown scripts are not run when envbox is terminated #76

spikecurtis opened this issue Jun 24, 2024 · 0 comments · Fixed by #83
Assignees
Labels
bug Something isn't working

Comments

@spikecurtis
Copy link

A customer is using envbox and setting Coder Agent shutdown scripts, but it doesn't appear these are being executed.

I suspect what's happening is that envbox is failing to propagate signals (especially SIGTERM) to the inner workspace agent process, meaning it never realizes it should be shut down until the whole envbox container and process tree is killed by the OS.

@sreya sreya closed this as completed in #83 Jul 19, 2024
@sreya sreya reopened this Sep 3, 2024
@coder-labeler coder-labeler bot added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants