Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass through signals to inner container #83

Merged
merged 15 commits into from
Jul 19, 2024
Merged

fix: pass through signals to inner container #83

merged 15 commits into from
Jul 19, 2024

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Jul 3, 2024 •
edited
Loading

fixes #76

@sreya sreya marked this pull request as ready for review July 19, 2024 19:47
@sreya sreya requested a review from coadler July 19, 2024 19:47
@sreya sreya merged commit c07d2c2 into main Jul 19, 2024
9 checks passed
@sreya sreya deleted the jon/signals branch July 19, 2024 20:04
sreya added a commit that referenced this pull request Aug 22, 2024
@sreya
Revert "fix: pass through signals to inner container (#83)"
3a2d7f2 
This reverts commit c07d2c2.
sreya added a commit that referenced this pull request Aug 22, 2024
@sreya
fix: revert signal pass through handling (#96)
f609e64 
* Revert "fix: add a 1m timeout to signal shutdown (#92)"

This reverts commit 0d37a62.

* Revert "fix: pass through signals to inner container (#83)"

This reverts commit c07d2c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent shutdown scripts are not run when envbox is terminated
2 participants
@sreya @coadler