Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass spurious reload button #32

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Bypass spurious reload button #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/vs/workbench/contrib/extensions/browser/extensionsActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,9 +1443,17 @@ export class ReloadAction extends ExtensionAction {
if (extensionInOtherServer) {
// This extension prefers to run on UI/Local side but is running in remote
if (runningExtensionServer === this.extensionManagementServerService.remoteExtensionManagementServer && this.extensionManifestPropertiesService.prefersExecuteOnUI(this.extension.local!.manifest)) {
this.enabled = true;
this.label = localize('reloadRequired', "Reload Required");
this.tooltip = localize('enable locally', "Please reload Visual Studio Code to enable this extension locally.");
/**
* This is causing builtin extensions to always show a reload
* button yet reloading does nothing.
* TODO@coder: The real problem might be that these extensions
* are somehow supposed to be running as web extensions instead
* of in the remote but it is unclear how to make that happen.
* @author coder
*/
// this.enabled = true;
// this.label = localize('reloadRequired', "Reload Required");
// this.tooltip = localize('enable locally', "Please reload Visual Studio Code to enable this extension locally.");
return;
}

Expand Down