Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass spurious reload button #32

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Bypass spurious reload button #32

merged 1 commit into from
Dec 23, 2021

Conversation

code-asher
Copy link
Member

This reload button does nothing which I think must mean there is some
logic somewhere that is supposed to load these extensions locally that
is not working or not implemented.

Until we find it bypassing is probably a good move because otherwise it
makes it look like the extension is not running and working even though
it really is (it is just running remotely).

This will be a temporary measure to solve
coder/code-server#4600.

As an aside, I tried upgrading to VS Code 1.63.2 but the problem persisted.

This reload button does nothing which I think must mean there is some
logic somewhere that is supposed to load these extensions locally that
is not working or not implemented.

Until we find it bypassing is probably a good move because otherwise it
makes it look like the extension is not running and working even though
it really is (it is just running remotely).

This will be a temporary measure to solve
coder/code-server#4600.
@code-asher code-asher requested a review from jsjoeio December 20, 2021 22:29
Copy link

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! It would be interesting to know if you're right about them running as web extensions. I wonder if this happens in Gitpod's implementation.

@code-asher
Copy link
Member Author

Good point! I checked and they do indeed have the same problem.

@code-asher code-asher merged commit 69a6ce4 into coder:main Dec 23, 2021
@code-asher code-asher deleted the bypass-local branch December 23, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants