-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.8.8 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we don't pollute the directory tree.
Closes #227
NetConn has to close the connection to interrupt in progress reads and writes. However, it can block reads and writes that occur after the deadline instead of closing the connection. Closes #228
Disable compression by default and switch to stdlib compress
Closes #248 Luckily, due to the 5s timeout on the close handshake, this would have had very minimal effects on anyone in production.
Thank you @icholy for identifying these in #259 (comment)
Merge master into dev
netconn.go: Disable read limit on WebSocket
Unfortunately going to have to delay this. The autobahn test suite is failing. |
40MB? 🤨. Or Kb? |
Glad no one ran into this in production.
Oh haha yes KB not MB. |
nhooyr
force-pushed
the
dev
branch
2 times, most recently
from
October 19, 2023 10:22
77f7262
to
e72696e
Compare
Release notes are complete. Docs have been updated. Will release Friday at noon. |
No longer needed :)
Underscores in symbols are ok sometimes...
Tricky tricky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will document release notes in this PR soon.