Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] Landing Page #2

Merged
merged 36 commits into from
Apr 4, 2021
Merged

[Add] Landing Page #2

merged 36 commits into from
Apr 4, 2021

Conversation

carms-ng
Copy link
Contributor

@carms-ng carms-ng commented Mar 28, 2021

  • Setup global styles, typeface: Young Serif pair with Share Tech), color scheme, site border
  • Header
  • Hero + Logo Garden
    Screenshot from 2021-03-28 14-27-54

@carms-ng carms-ng changed the title [Add] Landing Section [Add] Landing Page Mar 29, 2021
@carms-ng
Copy link
Contributor Author

carms-ng commented Mar 29, 2021

TODO:

  • Team Section
  • Contact Section
  • Wire contact form (Netlify?)
  • Fix Scroll Snap
  • Optimize Background images
  • Wire Page 2 / Agreement in PDF?
  • Improve Language Switcher
  • Add Translation

@rngadam
Copy link
Member

rngadam commented Mar 31, 2021

@Carms-dev

Very nice, I like the style so far!

I think I'd comment out the quantity of talents (3 bunkers, 50+ talents) for now and list the team with pics instead.

As we build the rooster of employees and collaborators (maybe visually distinguish both) and get a significant number of collaborators in Canada we can put those back. For now, we focus on highlighting the members of the team physically here.

@carms-ng
Copy link
Contributor Author

carms-ng commented Mar 31, 2021

@rngadam - Thanks for the feedback!

I think I'd comment out the quantity of talents (3 bunkers, 50+ talents) for now and list the team with pics instead.

Can you expand on list the team with pics? Something like this?
Screenshot from 2021-03-31 18-26-46

I will be adding the team members in the Consult Your Tech Lead section. We can do the stacked avatar above, or a call to action button, or leave it blank. Let me know!

Also can you send me Élic's pic? and others that you'd like to include?

@carms-ng
Copy link
Contributor Author

carms-ng commented Apr 1, 2021

@rngadam

Added Team Section

Screenshot from 2021-04-01 01-51-24

@rngadam
Copy link
Member

rngadam commented Apr 1, 2021

The stacked avatar is a good idea, I wasn't thinking of that but good suggestion.

here's the team as it is now from which I think you can get the profile pictures:

expected to add quickly more employees and more freelancers as we grow to the community. so it's important that whatever you build be easy to edit and customise.

I see you've got it as part of the team.js file which is already pretty easy to maintain, but I'd go a bit further and turn it into a team.json file that you fetch at runtime.

@carms-ng
Copy link
Contributor Author

carms-ng commented Apr 1, 2021

@rngadam

here's the team as it is now from which I think you can get the profile pictures:

Linkedin resizes profile pic. It's good enough for the stacked avatar, but not in the Team Section. When you have a chance, Can you provide the original for elic / andrea / manuel?

Thanks!

@rngadam
Copy link
Member

rngadam commented Apr 1, 2021

OK, sent email to request higher rez pics.

Once you get this pull request in, I suggest we break down the big main issue into smaller, more focused linked issues and have one pull request per issue so we can incrementally build the site.

@carms-ng
Copy link
Contributor Author

carms-ng commented Apr 2, 2021

  • Fix Android keyboard vh distortion
  • Deploy to netlify
  • Custom domain
  • Netlify form submit handling

@carms-ng
Copy link
Contributor Author

carms-ng commented Apr 2, 2021

Netlify - https://coderbunker.netlify.app/

@carms-ng
Copy link
Contributor Author

carms-ng commented Apr 3, 2021

Hey @rngadam - the broad stokes of the landing page is done🔥 I want to loop you or others in for the following

  • FR translation
  • Add the remaining profile & picture & profile
  • Replace the placeholder pdf when the Retainer Agreement PDF is ready
  • Update contact information
  • Custom domain set up on Netlify

@carms-ng carms-ng requested a review from rngadam April 3, 2021 03:57
@rngadam
Copy link
Member

rngadam commented Apr 3, 2021

  • look at validators online to validate the page
  • document the deployment steps and structure of code
  • deploy to coderbunker.ca (access to Google Domains)
  • Correct address:

Coderbunker Inc.
2-227 St-Paul
Quebec, QC G1K 3W3
+1 438-530-7111

  • production deployment from main and branches to staging

@carms-ng carms-ng merged commit ee80f41 into main Apr 4, 2021
@carms-ng carms-ng deleted the landing branch April 4, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants